Review main Merged

69797[BUGFIX] Show folder path to file when editing sys_file_metadata

Benni Mack CR +2 V +2 Normal +92 −62 updated 07/13/21, 09:19

Commit message

When editing the metadata of a file, the file is now
resolved in FormEngine, similar to what editors see
in the file list module.

In addition, the MetaInformation object now contains
a proper fileResource property, so the existing file
can be reused instead of being fetched again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1015

  1. Benni Mack uploaded patch set 1 07/09/21, 14:13

  2. core-ci voted on patch set 1 V -1 07/09/21, 14:26 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13152

  3. Jochen Roth uploaded patch set 2 07/09/21, 14:41

  4. core-ci voted on patch set 2 V -1 07/09/21, 14:55 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13155

  5. Oli Bartsch uploaded patch set 3 07/09/21, 19:35

  6. core-ci voted on patch set 3 V +1 07/09/21, 19:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13164

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 07/09/21, 19:56

  8. Benni Mack uploaded patch set 4 07/09/21, 22:04

  9. core-ci voted on patch set 4 V +1 07/09/21, 22:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13167

  10. Benni Mack uploaded patch set 5 07/13/21, 08:48

  11. Oli Bartsch voted on patch set 5 V +1 CR +1 07/13/21, 08:52

  12. core-ci voted on patch set 5 V +1 07/13/21, 09:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13274

  13. Jochen Roth voted on patch set 5 V +1 CR +1 07/13/21, 09:06

  14. Benni Mack voted on patch set 5 V +2 CR +2 07/13/21, 09:19

  15. Benni Mack merged patch set 6 07/13/21, 09:19