Review main Merged

69798[TASK] Streamline clipboard UI

Jochen Roth CR +2 V +2 Hard +151 −332 updated 07/13/21, 06:04

Commit message

The menu was removed because it contained
only already existing buttons (clear clipboard)
or buttons that do not belong to the clipboard
(delete, export) which made the clipboard
overly complicated.

Removed red color (danger) from clear all
button, because this is a non destructive
operation and added width/height for preview
images so SVG images are displayed as expected
in the clipboard.

In addition, the "move/copy" selector is now a
radio button, which finally works properly again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1930

Show 35 earlier messages
  1. Jochen Roth uploaded patch set 1 07/09/21, 15:36

  2. Jochen Roth updated the commit message in patch set 2 07/09/21, 15:38

  3. core-ci voted on patch set 1 V +1 07/09/21, 15:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13157

  4. core-ci voted on patch set 2 V +1 07/09/21, 15:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13158

  5. Benni Mack uploaded patch set 3 07/12/21, 07:36

  1. Benni Mack uploaded patch set 4 07/12/21, 07:40

  2. core-ci voted on patch set 3 V -1 07/12/21, 07:48 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13202

  3. core-ci voted on patch set 4 V -1 07/12/21, 07:56 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13204

  4. Benni Mack uploaded patch set 5 07/12/21, 09:08

  5. core-ci voted on patch set 5 V -1 07/12/21, 09:27 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13212

  6. Benni Mack uploaded patch set 6 07/12/21, 11:35

  7. core-ci voted on patch set 6 V -1 07/12/21, 11:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13225

  8. Benni Mack uploaded patch set 7 07/12/21, 14:17

  9. core-ci voted on patch set 7 V +1 07/12/21, 14:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13241

  10. Benni Mack commented on patch set 7 07/12/21, 14:37

    There are a lot more things to improve, but I think this is a good step forward.
  11. Benni Mack voted on patch set 7 V +1 CR +1 07/12/21, 15:22

  12. Oli Bartsch commented on patch set 7 CR -1 07/12/21, 19:30

    On it
  13. Oli Bartsch uploaded patch set 8 07/12/21, 20:21

  14. Oli Bartsch voted on patch set 8 V +1 CR +1 07/12/21, 20:22

  15. core-ci voted on patch set 8 V -1 07/12/21, 20:35 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13260

  16. Oli Bartsch uploaded patch set 9 07/12/21, 21:15

  17. core-ci voted on patch set 9 V +1 07/12/21, 21:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13263

  18. Oli Bartsch voted on patch set 9 V +1 CR +1 07/12/21, 21:30

  19. Jochen Roth uploaded patch set 10 07/12/21, 21:33

  20. Jochen Roth uploaded patch set 11 07/12/21, 21:43

  21. core-ci voted on patch set 10 V +1 07/12/21, 21:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13264

  22. core-ci voted on patch set 11 V +1 07/12/21, 21:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13265

  23. Oli Bartsch voted on patch set 11 V +1 CR +1 07/12/21, 22:33

  24. Benni Mack voted on patch set 11 V +2 CR +2 07/13/21, 06:04

  25. Benni Mack merged patch set 12 07/13/21, 06:04