Review main Merged

69800[BUGFIX] Enable ContextMenu for file mounts and file storages again

Oli Bartsch CR +2 V +2 Normal +3 −154 updated 07/12/21, 14:41

Commit message

The custom ContextMenu ItemProviders for sys_filemounts
and sys_file_storage are removed as they never worked,
because they extended the FileProvider, which uses
the combined identifier as record identifier instead of
the records uid. Also their $itemsConfiguration does not
make any sense. In the end, there is no reason to treat
those record types differently than the rest.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 68

  1. Oli Bartsch uploaded patch set 1 07/09/21, 21:40

  2. core-ci voted on patch set 1 V +1 07/09/21, 21:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13165

  3. Oli Bartsch uploaded patch set 2 07/12/21, 08:56

  4. core-ci voted on patch set 2 V +1 07/12/21, 09:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13209

  5. Benni Mack voted on patch set 2 V +1 CR +1 07/12/21, 11:15

  6. Jochen Roth voted on patch set 2 V +1 CR +1 07/12/21, 14:19

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 07/12/21, 14:41

  8. Oli Bartsch merged patch set 3 07/12/21, 14:41