Review main Merged

69805[TASK] Remove unused variables throughout core

Nikita Hovratov CR +2 V +2 Normal +23 −51 updated 07/12/21, 11:14

Commit message

Due to refactoring or very old code some places in the core define
unused variables or variables, which are immediately overridden.
They are mostly unnecessary. Even in places, where they might be
slightly helpful if defined at the beginning of a function, the benefit
doesn't excuse the existence.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 36

Show 16 more files

Review log 69

  1. Nikita Hovratov uploaded patch set 1 07/10/21, 16:38

  2. core-ci voted on patch set 1 V -1 07/10/21, 16:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13176

  3. Nikita Hovratov uploaded patch set 2 07/10/21, 16:45

  4. core-ci voted on patch set 2 V -1 07/10/21, 17:03 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13177

  5. Nikita Hovratov uploaded patch set 3 07/10/21, 17:37

  6. core-ci voted on patch set 3 V +1 07/10/21, 17:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13178

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 07/11/21, 10:52

  8. Benni Mack voted on patch set 3 V +2 CR +2 07/12/21, 11:14

  9. Benni Mack merged patch set 4 07/12/21, 11:14