69805[TASK] Remove unused variables throughout core
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 36
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+1 −1
- typo3/sysext/backend/Classes/Controller/BackendController.php+0 −1
- typo3/sysext/backend/Tests/Unit/Form/NodeFactoryTest.php+0 −2
- typo3/sysext/core/Classes/Core/Bootstrap.php+0 −2
- typo3/sysext/core/Classes/Database/Schema/Parser/TableBuilder.php+0 −1
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+7 −7
- typo3/sysext/core/Classes/Database/QueryGenerator.php+1 −1
- typo3/sysext/core/Classes/Database/QueryView.php+1 −1
- typo3/sysext/core/Classes/Database/SoftReferenceIndex.php+1 −1
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapItem.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+0 −2
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php+0 −1
- typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php+0 −1
- typo3/sysext/core/Classes/Mail/TransportFactory.php+0 −2
- typo3/sysext/core/Classes/Type/File/ImageInfo.php+0 −2
- typo3/sysext/core/Tests/Unit/DependencyInjection/ListenerProviderPassTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderCompilationPassTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Mail/FileSpoolTest.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+0 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+0 −1
Show 16 more files
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyObjectStorage.php+0 −1
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php+0 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/BackendTest.php+0 −1
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+0 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Middleware/PageResolverTest.php+0 −3
- typo3/sysext/indexed_search/Classes/FileContentParser.php+0 −1
- typo3/sysext/indexed_search/Classes/Indexer.php+0 −1
- typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php+1 −1
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+0 −1
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+2 −2
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php+0 −1
- typo3/sysext/redirects/Classes/Service/RedirectService.php+1 −1
Review log 69
-
Nikita Hovratov uploaded patch set 1 07/10/21, 16:38
-
core-ci voted on patch set 1 V -1 07/10/21, 16:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13176
-
Nikita Hovratov uploaded patch set 2 07/10/21, 16:45
-
core-ci voted on patch set 2 V -1 07/10/21, 17:03 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13177
-
Nikita Hovratov uploaded patch set 3 07/10/21, 17:37
-
core-ci voted on patch set 3 V +1 07/10/21, 17:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13178
-
Christian Kuhn voted on patch set 3 V +1 CR +1 07/11/21, 10:52
-
Benni Mack voted on patch set 3 V +2 CR +2 07/12/21, 11:14
-
Benni Mack merged patch set 4 07/12/21, 11:14