69809[TASK] Introduce SVG Sanitizer
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 53
- typo3/sysext/core/Classes/Resource/Security/SvgEventListener.phpnew+72 −0
- typo3/sysext/core/Classes/Resource/Security/SvgHookHandler.phpnew+48 −0
- typo3/sysext/core/Classes/Resource/Security/SvgSanitizer.phpnew+56 −0
- typo3/sysext/core/Classes/Resource/Security/SvgTypeCheck.phpnew+76 −0
- typo3/sysext/core/Configuration/Services.yaml+21 −0
- typo3/sysext/core/Documentation/Changelog/9.5.x/Important-94492-IntroduceSVGSanitizer.rstnew+39 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/ariaData.svgnew+57 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/billion_laughs.svgnew+0 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/entity.svgnew+4 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/entity_2.svgnew+4 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/external.svgnew+10 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/hrefOne.svgnew+13 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/hrefTwo.svgnew+13 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/html.svgnew+4 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/simple.svgnew+4 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/svgOne.svgnew+13 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/TYPO3_Logo_Clean.svgnew+7 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/TYPO3_Logo_Data.svgnew+8 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/TYPO3_Logo_Script.svgnew+7 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/use.svgnew+6 −0
Show 33 more files
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/useDos.svgnew+113 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/xlinkLaughs.svgnew+71 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/xlinkLoop.svgnew+24 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/xlink_laughs.svgnew+146 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/xmlOne.xmlnew+11 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/xss.svgnew+4 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/ariaData.svgnew+56 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/billion_laughs.svgnew+16 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/entity.svgnew+5 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/entity_2.svgnew+8 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/external.svgnew+11 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/hrefOne.svgnew+13 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/hrefTwo.svgnew+13 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/html.svgnew+14 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/simple.svgnew+5 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/svgOne.svgnew+15 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/TYPO3_Logo_Clean.svgnew+7 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/TYPO3_Logo_Data.svgnew+8 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/TYPO3_Logo_Script.svgnew+13 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/use.svgnew+5 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/useDos.svgnew+129 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/xlinkLaughs.svgnew+146 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/xlinkLoop.svgnew+31 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/xlink_laughs.svgnew+146 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/xmlOne.xmlnew+12 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/xss.svgnew+8 −0
- typo3/sysext/core/Tests/Functional/Resource/Security/SvgSanitizerTest.phpnew+60 −0
- typo3/sysext/core/composer.json+1 −0
- typo3/sysext/core/ext_localconf.php2+1 −0
- typo3/sysext/install/Classes/Updates/SvgFilesSanitization.phpnew+200 −0
- typo3/sysext/install/ext_localconf.php+2 −0
- composer.json+1 −0
- composer.lock+46 −1
Review log 2436
Show 611 earlier messages
-
Oliver Hader uploaded patch set 1 07/11/21, 12:18
-
core-ci voted on patch set 1 V -1 07/11/21, 12:36 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13187
-
Oliver Hader uploaded patch set 2 07/11/21, 12:38
-
core-ci voted on patch set 2 V -1 07/11/21, 12:52 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13188
-
Oliver Hader uploaded patch set 3 07/11/21, 13:23
-
Oliver Hader updated the commit message in patch set 4 07/11/21, 13:30
-
core-ci voted on patch set 3 V +1 07/11/21, 13:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13189
-
core-ci voted on patch set 4 V +1 07/11/21, 13:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13190
-
Oliver Hader updated the commit message in patch set 5 07/12/21, 08:31
-
core-ci voted on patch set 5 V +1 07/12/21, 08:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13206
-
Benni Mack commented on patch set 5 07/12/21, 09:18
ext_localconf.php:5use ::class syntax for GeneralUtility
-
Christian Kuhn commented on patch set 5 07/12/21, 09:41
typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/useDosTwo.svg (unable to comment inline) - do we really needs such a huge fixture file? That's 100k lines, all php core codelines together have 500k (?) as comparison. Which scenario is covered with that file? Could we pinpoint it with a reduced test set or multiple files, maybe? Not a critical thing and if the answer is "screw it, keep it as is", I can live with it ... just asking. -
Oliver Hader uploaded patch set 6 07/12/21, 09:45
-
Oliver Hader uploaded patch set 7 07/12/21, 09:47
-
Oliver Hader commented on patch set 7 07/12/21, 09:47
EventListener.php:24ReplyAckext_localconf.php:5ReplyAck -
Oliver Hader commented on patch set 7 07/12/21, 09:48
Reply
It's checking for amplification DoS attack... I don't care if it would be removed. -
Oliver Hader uploaded patch set 8 07/12/21, 09:50
-
Oliver Hader commented on patch set 8 07/12/21, 09:50
Reply
Removed it -
core-ci voted on patch set 8 V -1 07/12/21, 10:06 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13216
-
core-ci voted on patch set 7 V -1 07/12/21, 10:06 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13215
-
core-ci voted on patch set 6 V -1 07/12/21, 10:06 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13214
-
Oliver Hader uploaded patch set 9 07/12/21, 10:08
-
core-ci voted on patch set 9 V -1 07/12/21, 10:25 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13217
-
Oliver Hader uploaded patch set 10 07/12/21, 10:38
-
core-ci voted on patch set 10 V +1 07/12/21, 10:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13220
-
Benni Mack voted on patch set 10 CR +1 07/12/21, 11:05
-
Oliver Hader commented on patch set 10 CR -1 07/12/21, 14:46
adding Important.rst -
Oliver Hader uploaded patch set 11 07/12/21, 14:57
-
core-ci voted on patch set 11 V +1 07/12/21, 15:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13246
-
Oliver Hader voted on patch set 11 CR -1 07/12/21, 19:48
-
Oliver Hader uploaded patch set 12 07/12/21, 19:54
-
core-ci voted on patch set 12 V +1 07/12/21, 20:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13257
-
Benni Mack voted on patch set 12 V +1 CR +1 07/12/21, 20:11
-
Oli Bartsch voted on patch set 12 V +1 CR +1 07/12/21, 21:32
-
Oliver Hader voted on patch set 12 V +2 CR +2 07/12/21, 21:53
-
Oliver Hader merged patch set 13 07/12/21, 21:53
EventListener.php:24