Review TYPO3_4-6 Merged

6981[BUGFIX] Form: Add more semantic classes for elements

Oliver Hader CR +2 V +2 Normal +97 −7 updated 06/03/13, 20:49

Commit message

The system extension form renders elements with a wrapped class like
"csc-form-1" which just states the order of elements. To enable more
specific styling, a schema like the following is integrated:

csc-form-<id> csc-form-element csc-form-element-<type>

Review

  • Code review CR +2
    • Xavier Perseguers +2
  • Verified V +2
    • Xavier Perseguers +2
    • Philipp Gampe +1

Files 6

Review log 11

  1. Andreas Wolf uploaded patch set 2 03/06/12, 10:00

  2. Andreas Wolf uploaded patch set 3 03/06/12, 10:00

  3. Andreas Wolf commented on patch set 3 03/06/12, 10:00

    Verified; Looks good to me, approved Fixed a small issue in the commit message. Patch works fine and can be committed after an additional verification.
  4. Oliver Hader uploaded patch set 4 03/06/12, 10:00

  5. Oliver Hader commented on patch set 4 03/06/12, 10:00

    Verified; Looks good to me, but someone else must approve Automated rebasing to TYPO3_4-6 - Please consider updating your reviews V:1, R:1 as a summary of previous scores (limited to [-1;+1]) V:1, R:2 from Andreas Wolf <andreas.wolf@ikt-werk.de>
  6. Georg Ringer commented on patch set 1 03/06/12, 10:00

    Looks good to me, but someone else must approve
  7. Philipp Gampe commented on patch set 4 03/06/12, 10:00

    (1 inline comment)
    order *of* elements
  8. Philipp Gampe commented on patch set 5 V 0 03/06/12, 10:00

    Works for me.
  9. Philipp Gampe uploaded patch set 5 03/06/12, 10:00

  10. Xavier Perseguers commented on patch set 5 V 0 03/06/12, 10:00

    by team member; Looks good to me, approved Backported from master
  11. Xavier Perseguers merged patch set 5 03/06/12, 10:00