Review main Abandoned

69810[BUGFIX] Forward ext:form request arguments to the render action

waldhacker CR 0 V 0 Easy +3 −1 updated 07/13/21, 07:43

Commit message

Since the last request handling changes, the ext:form controller can no
longer correctly forward the requests to the render action because
the request arguments are lost.
This patch forwards all transferred arguments to the render action so
that the form runtime can process the request correctly again.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1012

  1. waldhacker uploaded patch set 1 07/11/21, 15:53

  2. core-ci voted on patch set 1 V +1 07/11/21, 16:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13191

  3. Christian Kuhn commented on patch set 1 07/11/21, 16:19

    FormFrontendController.php:92

    $this->request->getArguments() should do too, right?
  4. waldhacker commented on patch set 1 07/11/21, 16:26

    FormFrontendController.php:92 Reply Unresolved

    yes :)
  5. waldhacker commented on patch set 2 07/11/21, 16:29

    Published edit on patch set 1.
  6. core-ci voted on patch set 2 V +1 07/11/21, 16:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13192

  7. Helmut Hummel commented on patch set 2 07/12/21, 16:32

    FormFrontendController.php:92 Unresolved

    Isn't that something that should be fixed/changed in the handling of ForwardResponse? Arguments currently need to be set explicitly, while they previously were taken from current request. ExtensionName and ControllerName though are still taken from current request
  8. waldhacker commented on patch set 2 07/13/21, 06:09

  9. Oliver Hader commented on patch set 2 07/13/21, 07:41

    → reverted change that caused this behavior: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69779
  10. Oliver Hader commented on patch set 2 CR -1 07/13/21, 07:42

    Shall we abandon this one?
  11. waldhacker commented on patch set 2 07/13/21, 07:43

    Reply

    yes
  12. waldhacker abandoned the change 07/13/21, 07:43