69813[BUGFIX] Fix undefined array key warnings for PHP8
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/BackendLayoutWizardElement.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+10 −2
- typo3/sysext/core/Classes/Imaging/IconFactory.php+1 −1
- typo3/sysext/core/Classes/Resource/Service/UserFileInlineLabelService.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php4+5 −5
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/ElementsBasicInputEvalCest.php+3 −0
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/InlineFalCest.php+1 −1
- typo3/sysext/impexp/Classes/Import.php+13 −13
- typo3/sysext/impexp/Classes/ImportExport.php+1 −1
- typo3/sysext/linkvalidator/Classes/Repository/PagesRepository.php+1 −1
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+1 −1
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTaskAdditionalFieldProvider.php2+7 −7
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+14 −5
- typo3/sysext/recycler/Classes/Task/CleanerFieldProvider.php+2 −2
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+1 −1
Review log 1421
-
Jochen Roth uploaded patch set 1 07/12/21, 11:16
-
Jochen Roth updated the commit message in patch set 2 07/12/21, 11:19
-
core-ci voted on patch set 1 V -1 07/12/21, 11:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13222
-
core-ci voted on patch set 2 V -1 07/12/21, 11:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13223
-
Jochen Roth uploaded patch set 3 07/12/21, 12:45
-
core-ci voted on patch set 3 V -1 07/12/21, 12:59 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13232
-
Jochen Roth uploaded patch set 4 07/12/21, 18:51
-
Jochen Roth uploaded patch set 5 07/12/21, 18:55
-
core-ci voted on patch set 4 V +1 07/12/21, 19:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13254
-
core-ci voted on patch set 5 V +1 07/12/21, 19:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13255
-
Benni Mack voted on patch set 5 CR +1 07/12/21, 19:15
-
Benni Mack voted on patch set 5 V +1 07/12/21, 19:38
-
Oli Bartsch commented on patch set 5 07/12/21, 22:33
ExtendedTemplateService.php:835Any chance to make this strict?ExtendedTemplateService.php:838Are we sure this is always set?ValidatorTaskAdditionalFieldProvider.php:104Why do we mix bool and int here? -
Jochen Roth uploaded patch set 6 07/13/21, 10:08
-
core-ci voted on patch set 6 V +1 07/13/21, 10:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13277
-
Jochen Roth commented on patch set 6 07/13/21, 16:10
DataHandler.php:2878Reply UnresolvedSorry, missed that. Changed it. Thanks!ExtendedTemplateService.php:835ReplyDoneExtendedTemplateService.php:838Reply UnresolvedYes, i think so.ValidatorTaskAdditionalFieldProvider.php:104Reply UnresolvedChanged it. -
Oli Bartsch uploaded patch set 7 07/14/21, 15:10
-
core-ci voted on patch set 7 V +1 07/14/21, 15:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13320
-
Oli Bartsch voted on patch set 7 V +1 CR +1 07/14/21, 15:39
-
Benni Mack voted on patch set 7 V +2 CR +2 07/15/21, 08:03
-
Benni Mack merged patch set 8 07/15/21, 08:04
DataHandler.php:2878