Review main Merged

69813[BUGFIX] Fix undefined array key warnings for PHP8

Jochen Roth CR +2 V +2 Normal +64 −44 updated 07/15/21, 08:04

Commit message

Added fallback for undefined array keys
in backend, core, recycler, impexp, scheduler and
linkvalidator

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1421

  1. Jochen Roth uploaded patch set 1 07/12/21, 11:16

  2. Jochen Roth updated the commit message in patch set 2 07/12/21, 11:19

  3. core-ci voted on patch set 1 V -1 07/12/21, 11:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13222

  4. core-ci voted on patch set 2 V -1 07/12/21, 11:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13223

  5. Jochen Roth uploaded patch set 3 07/12/21, 12:45

  6. core-ci voted on patch set 3 V -1 07/12/21, 12:59 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13232

  7. Jochen Roth uploaded patch set 4 07/12/21, 18:51

  8. Jochen Roth uploaded patch set 5 07/12/21, 18:55

  9. core-ci voted on patch set 4 V +1 07/12/21, 19:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13254

  10. core-ci voted on patch set 5 V +1 07/12/21, 19:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13255

  11. Benni Mack voted on patch set 5 CR +1 07/12/21, 19:15

  12. Benni Mack voted on patch set 5 V +1 07/12/21, 19:38

  13. Oli Bartsch commented on patch set 5 07/12/21, 22:33

    DataHandler.php:2878

    In the else, those default to null. Why did you choose empty string here?

    ExtendedTemplateService.php:835

    Any chance to make this strict?

    ExtendedTemplateService.php:838

    Are we sure this is always set?

    ValidatorTaskAdditionalFieldProvider.php:104

    Why do we mix bool and int here?
  14. Jochen Roth uploaded patch set 6 07/13/21, 10:08

  15. core-ci voted on patch set 6 V +1 07/13/21, 10:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13277

  16. Jochen Roth commented on patch set 6 07/13/21, 16:10

    DataHandler.php:2878 Reply Unresolved

    Sorry, missed that. Changed it. Thanks!

    ExtendedTemplateService.php:835 Reply

    Done

    ExtendedTemplateService.php:838 Reply Unresolved

    Yes, i think so.

    ValidatorTaskAdditionalFieldProvider.php:104 Reply Unresolved

    Changed it.
  17. Oli Bartsch uploaded patch set 7 07/14/21, 15:10

  18. core-ci voted on patch set 7 V +1 07/14/21, 15:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13320

  19. Oli Bartsch voted on patch set 7 V +1 CR +1 07/14/21, 15:39

  20. Benni Mack voted on patch set 7 V +2 CR +2 07/15/21, 08:03

  21. Benni Mack merged patch set 8 07/15/21, 08:04