69814[BUGFIX] Show SVG actions in Element Browser trees
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Jochen Roth +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/Sass/component/_svgtree.scss+2 −2
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/FileStorageBrowser.ts+2 −16
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/PageBrowser.ts+3 −17
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/SvgTree.ts+36 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageBrowser.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/PageBrowser.js+3 −3
- typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js+1 −1
- typo3/sysext/recordlist/Resources/Public/JavaScript/RecordExportButton.jsnew+13 −0
Review log 1014
-
Benni Mack uploaded patch set 1 07/12/21, 13:50
-
core-ci voted on patch set 1 V +1 07/12/21, 13:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13238
-
Benni Mack updated the commit message in patch set 2 07/12/21, 14:00
-
core-ci voted on patch set 2 V +1 07/12/21, 14:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13239
-
Benni Mack uploaded patch set 3 07/12/21, 14:14
-
core-ci voted on patch set 3 V +1 07/12/21, 14:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13240
-
Jochen Roth commented on patch set 3 V +1 CR +1 07/12/21, 15:13
Maybe the action icon could have a bit more margin to avoid issues with a overlaying scrollbar. Just a thought. -
Benni Mack commented on patch set 3 07/12/21, 15:24
Reply
Yes. I think there is room for improvement when it comes to styling (also with "scrollbars" like MacOS and Safari does, this is a bit ugly to deal with, so I thought - first fix the functionality, then optimize across all browsers). -
Jochen Roth uploaded patch set 4 07/12/21, 16:03
-
core-ci voted on patch set 4 V +1 07/12/21, 16:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13249
-
Jochen Roth commented on patch set 4 V +1 CR +1 07/12/21, 16:46
Reply
For now just gave it a bit space so it stays clickable while scrollbar is displayed. Tested on MacOs Chrome and Firefox. -
Oli Bartsch voted on patch set 4 V +1 CR +1 07/12/21, 17:14
-
Benni Mack voted on patch set 4 V +2 CR +2 07/12/21, 17:43
-
Benni Mack merged patch set 5 07/12/21, 17:43