Review main Merged

69814[BUGFIX] Show SVG actions in Element Browser trees

Benni Mack CR +2 V +2 Normal +62 −43 updated 07/12/21, 17:43

Commit message

Due to the change of scalable SVG icons the tree actions
for selecting actions in the Page Selector / File Selector
were not rendered again.

This change fixes the issue by properly using a SVG
inside another SVG again, just like with icons
of the actual tree.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1014

  1. Benni Mack uploaded patch set 1 07/12/21, 13:50

  2. core-ci voted on patch set 1 V +1 07/12/21, 13:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13238

  3. Benni Mack updated the commit message in patch set 2 07/12/21, 14:00

  4. core-ci voted on patch set 2 V +1 07/12/21, 14:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13239

  5. Benni Mack uploaded patch set 3 07/12/21, 14:14

  6. core-ci voted on patch set 3 V +1 07/12/21, 14:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13240

  7. Jochen Roth commented on patch set 3 V +1 CR +1 07/12/21, 15:13

    Maybe the action icon could have a bit more margin to avoid issues with a overlaying scrollbar. Just a thought.
  8. Benni Mack commented on patch set 3 07/12/21, 15:24

    Reply

    Yes. I think there is room for improvement when it comes to styling (also with "scrollbars" like MacOS and Safari does, this is a bit ugly to deal with, so I thought - first fix the functionality, then optimize across all browsers).
  9. Jochen Roth uploaded patch set 4 07/12/21, 16:03

  10. core-ci voted on patch set 4 V +1 07/12/21, 16:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13249

  11. Jochen Roth commented on patch set 4 V +1 CR +1 07/12/21, 16:46

    Reply

    For now just gave it a bit space so it stays clickable while scrollbar is displayed. Tested on MacOs Chrome and Firefox.
  12. Oli Bartsch voted on patch set 4 V +1 CR +1 07/12/21, 17:14

  13. Benni Mack voted on patch set 4 V +2 CR +2 07/12/21, 17:43

  14. Benni Mack merged patch set 5 07/12/21, 17:43