Review main Merged

69815[BUGFIX] Hash identifier of Flexform sections

Andreas Kienast CR +2 V +2 Easy +4 −3 updated 08/03/21, 20:32

Commit message

To avoid issues with Flexform section identifiers having any reserved
character in CSS context, e.g. a dot, the identifier is now hashed to
be able to find the container via `querySelector()`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Guido Schmechel +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1214

  1. Andreas Kienast uploaded patch set 1 07/12/21, 14:24

  2. Benni Mack voted on patch set 1 CR +1 07/12/21, 14:26

  3. core-ci voted on patch set 1 V -1 07/12/21, 14:38 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13243

  4. Andreas Kienast uploaded patch set 2 07/12/21, 14:50

  5. core-ci voted on patch set 2 V +1 07/12/21, 15:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13245

  6. Tymoteusz Motylewski voted on patch set 2 V +1 CR +1 07/12/21, 18:24

  7. Tymoteusz Motylewski voted on patch set 2 V 0 07/12/21, 18:24

  8. Guido Schmechel commented on patch set 2 07/30/21, 23:30

    FlexFormSectionContainer.php:75

    Short question: Is it perhaps better to use the wrapper function GeneralUtility::shortMD5() here to avoid a direct md5()?
  9. Andreas Kienast commented on patch set 2 07/31/21, 06:11

    FlexFormSectionContainer.php:75 Reply

    I don't think this will have any benefit for us.
  10. Guido Schmechel voted on patch set 2 CR +1 07/31/21, 08:43

  11. Christian Kuhn commented on patch set 2 07/31/21, 10:50

    FlexFormSectionContainer.php:75 Reply Unresolved

    please don't. shortMD5 is simply too collision prone, even though it's only used in those non-security related things. it should be avoided and deprecated. find a nasty indexed_search issue on forge on what happens when shortMD5 is used.
  12. Oli Bartsch voted on patch set 2 V +1 CR +1 08/02/21, 23:21

  13. Benni Mack voted on patch set 2 V +2 CR +2 08/03/21, 20:32

  14. Benni Mack merged patch set 3 08/03/21, 20:32