69815[BUGFIX] Hash identifier of Flexform sections
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Guido Schmechel +1
- Tymoteusz Motylewski +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1214
-
Andreas Kienast uploaded patch set 1 07/12/21, 14:24
-
Benni Mack voted on patch set 1 CR +1 07/12/21, 14:26
-
core-ci voted on patch set 1 V -1 07/12/21, 14:38 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13243
-
Andreas Kienast uploaded patch set 2 07/12/21, 14:50
-
core-ci voted on patch set 2 V +1 07/12/21, 15:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13245
-
Tymoteusz Motylewski voted on patch set 2 V +1 CR +1 07/12/21, 18:24
-
Tymoteusz Motylewski voted on patch set 2 V 0 07/12/21, 18:24
-
Guido Schmechel commented on patch set 2 07/30/21, 23:30
-
Andreas Kienast commented on patch set 2 07/31/21, 06:11
FlexFormSectionContainer.php:75ReplyI don't think this will have any benefit for us. -
Guido Schmechel voted on patch set 2 CR +1 07/31/21, 08:43
-
Christian Kuhn commented on patch set 2 07/31/21, 10:50
FlexFormSectionContainer.php:75Reply Unresolvedplease don't. shortMD5 is simply too collision prone, even though it's only used in those non-security related things. it should be avoided and deprecated. find a nasty indexed_search issue on forge on what happens when shortMD5 is used. -
Oli Bartsch voted on patch set 2 V +1 CR +1 08/02/21, 23:21
-
Benni Mack voted on patch set 2 V +2 CR +2 08/03/21, 20:32
-
Benni Mack merged patch set 3 08/03/21, 20:32
FlexFormSectionContainer.php:75