Review 10.4 Merged

69816[TASK] Improve exception messages in ImageService

Oli Bartsch CR +2 V +2 Easy +34 −10 updated 07/12/21, 17:15

Commit message

The Extbase ImageService contains a helper method
`getImage()`. This method tries to find an image in a
couple of different ways, depending on the given input
arguments.

To improve the usability, the exception messages are
now dedicated to their corresponding try. As a side
effect, the method is now also more readable as it
now uses guard clauses and also contains a couple
of code comments.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch uploaded patch set 1 07/12/21, 17:02

  2. core-ci voted on patch set 1 V +1 07/12/21, 17:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13252

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 07/12/21, 17:15

  4. Oli Bartsch merged patch set 2 07/12/21, 17:15