Review main Merged

69823[FEATURE] Add filter option "Never hit" to Redirects module

Oli Bartsch CR +2 V +2 Normal +65 −4 updated 07/14/21, 15:49

Commit message

The Redirects module is extended for a new filter option
"Never hit". When used, the list is filtered for redirects,
which were never hit before. This is especially handy
for editors managing large sites, while the "automatic
redirect generation on slug change" is enabled.

The redirect demand already features the property
"maxHits", which however was previously only used
for the CLI command and is now also used for the
new filter option.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 811

  1. Oli Bartsch uploaded patch set 1 07/13/21, 11:42

  2. Oli Bartsch uploaded patch set 2 07/13/21, 11:47

  3. core-ci voted on patch set 1 V +1 07/13/21, 11:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13278

  4. core-ci voted on patch set 2 V +1 07/13/21, 12:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13279

  5. Oli Bartsch uploaded patch set 3 07/13/21, 12:32

  6. core-ci voted on patch set 3 V +1 07/13/21, 12:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13283

  7. Benni Mack voted on patch set 3 CR +1 07/14/21, 08:45

  8. Jochen Roth voted on patch set 3 V +1 CR +1 07/14/21, 13:42

  9. Benni Mack voted on patch set 3 V +2 CR +2 07/14/21, 14:04

  10. Benni Mack merged patch set 4 07/14/21, 14:57

  11. Daniel Goerz commented on patch set 4 07/14/21, 15:49