Review main Merged

69825[TASK] Enforce trailing commas in multi line arrays with PHP CS Fixer

Sebastian Michaelsen CR +2 V +2 Impossible +11427 −11426 updated 09/24/21, 09:06

Commit message

The rule trailing_comma_in_multiline is added to the PHP CS fixer
configuration.

This reduces possible merge conflicts in the future.

The commands to apply the rules over the code base was

./bin/php-cs-fixer fix \
    --path-mode intersection \
    --config=Build/php-cs-fixer.php \
    typo3/sysext

And then:
./bin/php-cs-fixer fix --config=Build/php-cs-fixer.php

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1222

Show 1202 more files

Review log 1218

  1. Sebastian Michaelsen uploaded patch set 1 07/13/21, 12:09

  2. core-ci voted on patch set 1 V +1 07/13/21, 12:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13281

  3. Sebastian Michaelsen rebased onto patch set 2 07/14/21, 13:28

  4. core-ci voted on patch set 2 V +1 07/14/21, 13:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13318

  5. Benni Mack uploaded patch set 3 09/07/21, 19:16

  6. core-ci voted on patch set 3 V +1 09/07/21, 19:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16386

  7. Benni Mack uploaded patch set 4 09/22/21, 14:44

  8. Sebastian Michaelsen commented on patch set 4 CR +1 09/22/21, 15:06

    Thanks for taking care
  9. core-ci voted on patch set 4 V +1 09/22/21, 15:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17047

  10. Thomas Löffler voted on patch set 4 CR +1 09/22/21, 16:16

  11. Benni Mack uploaded patch set 5 09/24/21, 08:04

  12. Benni Mack uploaded patch set 6 09/24/21, 08:06

  13. core-ci voted on patch set 5 V +1 09/24/21, 08:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17138

  14. core-ci voted on patch set 6 V +1 09/24/21, 08:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17140

  15. Andreas Kienast voted on patch set 6 V +1 CR +1 09/24/21, 08:31

  16. Wouter Wolters voted on patch set 6 V +1 CR +1 09/24/21, 09:05

  17. Benni Mack voted on patch set 6 V +2 CR +2 09/24/21, 09:06

  18. Benni Mack merged patch set 7 09/24/21, 09:06