Review 9.5 Merged

69826[BUGFIX] Correctly resolve best matching FAL storage

Oliver Hader CR +2 V +2 Hard +341 −19 updated 07/13/21, 14:12

Commit message

For legacy reasons storage resolving in file abstraction layer still
supports using identifiers like `/fileadmin/img.png` instead of
`1:/img.png` (given, that `1:` corresponds to `fileadmin/` storage).

To resolve the "best matching storage", existing storage paths are
analyzed - however this did not work in the following cases:

+ identifier like `/fileadmin/img.png` on storage using relative
  base-path like `fileadmin/`
+ identifier using absolute path on storage with relative base-path
+ identifier using relative path on storage with absolute base-path

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Oliver Hader uploaded patch set 1 07/13/21, 13:38

  2. core-ci voted on patch set 1 V +1 07/13/21, 13:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13290

  3. Oliver Hader voted on patch set 1 V +2 CR +2 07/13/21, 14:11

  4. Oliver Hader merged patch set 2 07/13/21, 14:12