Review main Merged

69830[BUGFIX] Fix several issues regarding Recordlist search

Oli Bartsch CR +2 V +2 Normal +77 −56 updated 07/21/21, 07:16

Commit message

Since #93892, clearing the search field did not longer
submit the form. This is now fixed by adding a dedicated
JS module, listening on the browsers "search" event.

When using the search in the Record selector, the search
options dropdown is now not longer cut off, in case no
search results are present.

Additionally, the functionality to toggle the search field
in the recordlist module is now moved into the Recordlist
JS module, as it does not belong to EXT:backend and
furthermore does not require a dedicated JS module.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 710

  1. Oli Bartsch uploaded patch set 1 07/13/21, 21:47

  2. Oli Bartsch updated the commit message in patch set 2 07/13/21, 22:00

  3. core-ci voted on patch set 1 V -1 07/13/21, 22:01 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13305

  4. core-ci voted on patch set 2 V -1 07/13/21, 22:15 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13307

  5. Oli Bartsch uploaded patch set 3 07/14/21, 00:49

  6. core-ci voted on patch set 3 V +1 07/14/21, 01:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13311

  7. Jochen Roth voted on patch set 3 V +1 CR +1 07/14/21, 13:28

  8. Guido Schmechel voted on patch set 3 V +1 07/16/21, 13:51

  9. Benni Mack voted on patch set 3 V +2 CR +2 07/21/21, 07:16

  10. Benni Mack merged patch set 4 07/21/21, 07:16