Review main Merged

69832[FEATURE] Allow overriding fileFolder config with TSconfig

Oli Bartsch CR +2 V +2 Hard +424 −33 updated 07/16/21, 15:17

Commit message

The "fileFolder" configuration options, available for TCA
columns of type "select" are used to fill the select field
with predefined files (images / icons). Nowadays this is
frequently used to make a corporate icon set available for
editors. In multi site installations however, those icon sets
usually differ from site to site.

Therefore, the AbstractItemProvider is now extended to allow
overriding those settings with TSconfig (TCEFORM).

Furthermore, to streamline the TCA configuration and to be
in line with the corresponding overrides, the "fileFolder"
TCA configuration options are moved into a dedicated sub array
"fileFolderConfiguration" and the properties are renamed
to be consistent with other TCA options.

* fileFolder => folder
* fileFolder_extList => allowedExtensions
* fileFolder_recursions => depth

A TCA migration is in place.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1117

  1. Oli Bartsch uploaded patch set 1 07/14/21, 00:22

  2. Oli Bartsch updated the commit message in patch set 2 07/14/21, 00:27

  3. core-ci voted on patch set 1 V +1 07/14/21, 00:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13309

  4. core-ci voted on patch set 2 V +1 07/14/21, 00:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13310

  5. Oli Bartsch uploaded patch set 3 07/14/21, 10:24

  6. core-ci voted on patch set 3 V +1 07/14/21, 10:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13315

  7. Jochen Roth voted on patch set 3 V +1 CR +1 07/14/21, 14:30

  8. Jochen Roth uploaded patch set 4 07/14/21, 14:45

  9. Jochen Roth voted on patch set 4 V +1 CR +1 07/14/21, 14:53

  10. core-ci voted on patch set 4 V +1 07/14/21, 14:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13319

  11. Oli Bartsch uploaded patch set 5 07/16/21, 11:31

  12. Oli Bartsch uploaded patch set 6 07/16/21, 11:36

  13. core-ci voted on patch set 5 V +1 07/16/21, 11:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13386

  14. core-ci voted on patch set 6 V +1 07/16/21, 11:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13387

  15. Jochen Roth voted on patch set 6 V +1 CR +1 07/16/21, 12:33

  16. Benni Mack voted on patch set 6 V +2 CR +2 07/16/21, 15:16

  17. Benni Mack merged patch set 7 07/16/21, 15:17