69856[TASK] Backport SecurityUtility.stripHtml()
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
-
Verified V +2 Done
- Oliver Hader +2
- core-ci +1 CI
Issues 2
Files 2
Review log 1114
-
Andreas Kienast uploaded patch set 1 07/14/21, 18:40
-
Andreas Kienast uploaded patch set 2 07/14/21, 18:41
-
core-ci voted on patch set 1 V -1 07/14/21, 18:54 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13334
-
core-ci voted on patch set 2 V +1 07/14/21, 18:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13335
-
Andreas Kienast commented on patch set 2 07/14/21, 19:01
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 07/14/21, 19:10
-
Oliver Hader commented on patch set 2 CR -1 07/15/21, 06:50
SecurityUtility.ts:74ReplyWe only use PhantomJS for testing, don't we? DOMParser was available in Internet Explorer 10 (https://developer.mozilla.org/en-US/docs/Web/API/DOMParser#browser_compatibility)... -
Andreas Kienast commented on patch set 2 07/15/21, 06:55
SecurityUtility.ts:74ReplyYes, we use PhantomJS only. The issue is that PhantomJS is in a pretty bad shape and doesn't support DOMParser('foo', 'text/html'), the text/html thing is the crucial part. -
Andreas Kienast uploaded patch set 3 07/15/21, 07:23
-
core-ci voted on patch set 3 V +1 07/15/21, 07:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13350
-
Oliver Hader commented on patch set 3 07/15/21, 08:34
JavaScript test intentionally skipped, due to missing support in (out-dated) PhantomJS version for `DOMParser`. -
Oliver Hader voted on patch set 3 V +2 CR +2 07/15/21, 08:34
-
Oliver Hader commented on patch set 3 07/15/21, 08:35
SecurityUtility.ts:74ReplyDone -
Oliver Hader merged patch set 4 07/15/21, 08:35
SecurityUtility.ts:74