69857[TASK] Refactor ViewHelper tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 120
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconForRecordViewHelperTest.phpnew+47 −0
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconViewHelperTest.phpnew+93 −0
- typo3/sysext/core/Tests/Unit/ViewHelpers/IconForRecordViewHelperTest.phpdeleted+0 −80
- typo3/sysext/core/Tests/Unit/ViewHelpers/IconViewHelperTest.phpdeleted+0 −136
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/README.md+1 −1
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/Link/FileViewHelper/Folders/fileadmin/user_upload/typo3_image2.jpgrenamedbinary
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/Link/FileViewHelper/Folders/fileadmin/_processed_/csm_typo3_image2_5c2670fd59.jpgrenamedbinary
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/Link/FileViewHelper/DatabaseImport.xmlrenamed+0 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/Link/FileViewHelper/Template.htmlrenamed+0 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/ExtendsAbstractEntity.phprenamed+3 −4
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/ImageViewHelperTest.jpgnewbinary
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/UserDomainClass.phpnew+50 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/UserDomainClassToString.phpnew+29 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/pages.csvnew+9 −0
- typo3/sysext/fluid/Tests/Functional/View/TemplatesPathsTest.php+1 −8
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Asset/ScriptViewHelperTest.phprenamed+7 −22
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/Security/IfAuthenticatedViewHelperTest.phpnew+48 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/Security/IfHasRoleViewHelperTest.phpnew+70 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/LinkViewHelperTest.phpnew+59 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/UriViewHelperTest.phpnew+59 −0
Show 100 more files
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Fixtures/link_typolink_additionalAttributes.htmldeleted+0 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Fixtures/link_typolink_parts.htmldeleted+0 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Fixtures/link_typolink_viewhelper.htmldeleted+0 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Fixtures/pages.xmldeleted+0 −8
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Fixtures/uri_typolink_viewhelper.htmldeleted+0 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/Select/OptionViewHelperTest.phpnew+177 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/ButtonViewHelperTest.phpnew+44 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/CheckboxViewHelperTest.phpnew+217 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/HiddenViewHelperTest.phpnew+34 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/PasswordViewHelperTest.phpnew+44 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/RadioViewHelperTest.phpnew+188 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/SelectViewHelperTest.phpnew+534 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/SubmitViewHelperTest.phpnew+34 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/TextareaViewHelperTest.phpnew+95 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/TextfieldViewHelperTest.phpnew+87 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/UploadViewHelperTest.phpnew+84 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/BytesViewHelperTest.phpnew+87 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/CaseViewHelperTest.phpnew+98 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/CropViewHelperTest.phpnew+61 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/CurrencyViewHelperTest.phpnew+101 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/DateViewHelperTest.phpnew+232 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/HtmlentitiesDecodeViewHelperTest.phpnew+91 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/HtmlentitiesViewHelperTest.phpnew+132 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/Nl2brViewHelperTest.phpnew+53 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/NumberViewHelperTest.phpnew+61 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/PaddingViewHelperTest.phpnew+68 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/StripTagsViewHelperTest.phpnew+85 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/UrlencodeViewHelperTest.phpnew+77 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/EmailViewHelperTest.phpnew+120 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/ExternalViewHelperTest.phpnew+53 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/FileViewHelperTest.php+4 −5
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/PageViewHelperTest.phpnew+78 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/TypolinkViewHelperTest.phpnew+193 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Security/IfAuthenticatedViewHelperTest.phpnew+58 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Security/IfHasRoleViewHelperTest.phpnew+75 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/EmailViewHelperTest.phpnew+98 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ExternalViewHelperTest.phpnew+57 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/PageViewHelperTest.phpnew+78 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/TypolinkViewHelperTest.phpnew+130 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/CObjectViewHelperTest.phpnew+146 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FlashMessagesViewHelperTest.phpnew+61 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FormViewHelperTest.php2+119 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.phpnew+80 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/TranslateViewHelperTest.phpnew+79 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/TypolinkViewHelperTest.phpdeleted+0 −384
- typo3/sysext/fluid/Tests/Functional/EscapeChildrenRenderingStandaloneTest.php+5 −10
- typo3/sysext/fluid/Tests/Functional/EscapeChildrenRenderingTest.php+4 −8
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Be/Security/IfAuthenticatedViewHelperTest.phpdeleted+0 −82
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Be/Security/IfHasRoleViewHelperTest.phpdeleted+0 −116
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Be/LinkViewHelperTest.phpdeleted+0 −107
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Be/UriViewHelperTest.phpdeleted+0 −109
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Fixtures/TranslateViewHelperFixtureForEmptyString.phpdeleted+0 −38
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/Fixtures/ClassWithTwoGetters.phpdeleted+0 −40
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/Fixtures/EmptyClass.phpdeleted+0 −23
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/Fixtures/EmptySyntaxTreeNode.phpdeleted+0 −28
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/Fixtures/UserDomainClass.phpdeleted+0 −72
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/Select/OptionViewHelperTest.phpdeleted+0 −223
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/AbstractFormFieldViewHelperTest.phpdeleted+0 −545
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/AbstractFormViewHelperTest.phpdeleted+0 −112
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/ButtonViewHelperTest.phpdeleted+0 −84
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/CheckboxViewHelperTest.phpdeleted+0 −385
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/FormFieldViewHelperBaseTestcase.phpdeleted+0 −104
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/HiddenViewHelperTest.phpdeleted+0 −58
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/PasswordViewHelperTest.phpdeleted+0 −90
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/RadioViewHelperTest.phpdeleted+0 −325
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/SelectViewHelperTest.phpdeleted+0 −625
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/SubmitViewHelperTest.phpdeleted+0 −55
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/TextareaViewHelperTest.phpdeleted+0 −148
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/TextfieldViewHelperTest.phpdeleted+0 −133
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/UploadViewHelperTest.phpdeleted+0 −109
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/BytesViewHelperTest.phpdeleted+0 −164
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/CaseViewHelperTest.phpdeleted+0 −134
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/CropViewHelperTest.phpdeleted+0 −124
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/CurrencyViewHelperTest.phpdeleted+0 −214
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/DateViewHelperTest.phpdeleted+0 −436
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/HtmlentitiesDecodeViewHelperTest.phpdeleted+0 −159
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/HtmlentitiesViewHelperTest.phpdeleted+0 −239
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/Nl2brViewHelperTest.phpdeleted+0 −94
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/NumberViewHelperTest.phpdeleted+0 −119
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/PaddingViewHelperTest.phpdeleted+0 −136
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/StripTagsViewHelperTest.phpdeleted+0 −143
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/UrlencodeViewHelperTest.phpdeleted+0 −145
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/EmailViewHelperTest.phpdeleted+0 −181
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/ExternalViewHelperTest.phpdeleted+0 −136
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/PageViewHelperTest.phpdeleted+0 −93
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/TypolinkViewHelperTest.php+5 −106
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Security/IfAuthenticatedViewHelperTest.phpdeleted+0 −91
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Security/IfHasRoleViewHelperTest.phpdeleted+0 −122
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/EmailViewHelperTest.phpdeleted+0 −65
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/ExternalViewHelperTest.phpdeleted+0 −104
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/PageViewHelperTest.phpdeleted+0 −83
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/TypolinkViewHelperTest.php+6 −13
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/CObjectViewHelperTest.phpdeleted+0 −252
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FlashMessagesViewHelperTest.phpdeleted+0 −120
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php+2 −283
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/ImageViewHelperTest.phpdeleted+0 −314
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/TranslateViewHelperTest.phpdeleted+0 −122
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/BaseViewHelperTest.phpdeleted+0 −50
- typo3/sysext/install/Tests/Functional/ViewHelpers/Format/PhpErrorCodeViewHelperTest.phpnew+63 −0
- typo3/sysext/install/Tests/Unit/ViewHelpers/Format/PhpErrorCodeViewHelperTest.phpdeleted+0 −81
Review log 3363
Show 1938 earlier messages
-
Christian Kuhn uploaded patch set 1 07/14/21, 21:59
-
Christian Kuhn uploaded patch set 2 07/14/21, 22:00
-
core-ci voted on patch set 1 V -1 07/14/21, 22:01 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13338
-
core-ci voted on patch set 2 V -1 07/14/21, 22:12 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13339
-
Christian Kuhn uploaded patch set 3 07/14/21, 22:25
-
core-ci voted on patch set 3 V +1 07/14/21, 22:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13340
-
Christian Kuhn uploaded patch set 4 07/14/21, 23:18
-
core-ci voted on patch set 4 V +1 07/14/21, 23:31 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13341
-
Christian Kuhn uploaded patch set 5 07/14/21, 23:42
-
core-ci voted on patch set 5 V -1 07/14/21, 23:50 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13342
-
Christian Kuhn uploaded patch set 6 07/15/21, 00:11
-
core-ci voted on patch set 6 V -1 07/15/21, 00:23 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13343
-
Christian Kuhn uploaded patch set 7 07/15/21, 00:37
-
core-ci voted on patch set 7 V -1 07/15/21, 00:51 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13344
-
Christian Kuhn uploaded patch set 8 07/15/21, 00:58
-
core-ci voted on patch set 8 V -1 07/15/21, 01:11 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13345
-
Christian Kuhn uploaded patch set 9 07/16/21, 13:58
-
Christian Kuhn uploaded patch set 10 07/16/21, 14:39
-
core-ci voted on patch set 9 V +1 07/16/21, 15:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13392
-
core-ci voted on patch set 10 V -1 07/16/21, 15:05 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13393
-
Christian Kuhn uploaded patch set 11 07/16/21, 15:43
-
Christian Kuhn uploaded patch set 12 07/16/21, 15:53
-
core-ci voted on patch set 11 V +1 07/16/21, 15:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13395
-
core-ci voted on patch set 12 V -1 07/16/21, 16:05 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13396
-
Christian Kuhn uploaded patch set 13 07/16/21, 16:11
-
core-ci voted on patch set 13 V -1 07/16/21, 16:22 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13397
-
Christian Kuhn uploaded patch set 14 07/17/21, 09:16
-
core-ci voted on patch set 14 V +1 07/17/21, 09:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13411
-
Christian Kuhn uploaded patch set 15 07/17/21, 18:55
-
core-ci voted on patch set 15 V -1 07/17/21, 19:07 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13417
-
Christian Kuhn uploaded patch set 16 07/17/21, 20:58
-
Christian Kuhn uploaded patch set 17 07/17/21, 21:08
-
core-ci voted on patch set 16 V -1 07/17/21, 21:11 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13418
-
core-ci voted on patch set 17 V +1 07/17/21, 21:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13419
-
Christian Kuhn uploaded patch set 18 07/18/21, 19:19
-
Christian Kuhn uploaded patch set 19 07/18/21, 19:20
-
core-ci voted on patch set 18 V -1 07/18/21, 19:22 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13456
-
core-ci voted on patch set 19 V +1 07/18/21, 19:32 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13457
-
Christian Kuhn uploaded patch set 20 07/18/21, 20:14
-
core-ci voted on patch set 20 V +1 07/18/21, 20:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13458
-
Christian Kuhn uploaded patch set 21 07/18/21, 22:11
-
core-ci voted on patch set 21 V -1 07/18/21, 22:23 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13459
-
Christian Kuhn updated the commit message in patch set 22 07/18/21, 22:33
-
core-ci voted on patch set 22 V -1 07/18/21, 22:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13460
-
core-ci commented on patch set 22 07/18/21, 22:50 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13460
-
core-ci commented on patch set 22 07/18/21, 22:58 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13460
-
core-ci commented on patch set 22 07/18/21, 23:14 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13460
-
Christian Kuhn uploaded patch set 23 07/19/21, 08:52
-
core-ci voted on patch set 23 V -1 07/19/21, 09:05 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13473
-
Christian Kuhn uploaded patch set 24 07/19/21, 10:04
-
core-ci voted on patch set 24 V +1 07/19/21, 10:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13476
-
Christian Kuhn rebased onto patch set 25 07/19/21, 11:22
-
Christian Kuhn uploaded patch set 26 07/19/21, 11:23
-
core-ci voted on patch set 26 V +1 07/19/21, 11:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13484
-
core-ci voted on patch set 25 V +1 07/19/21, 11:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13483
-
Jochen Roth commented on patch set 26 07/19/21, 13:23
-
Christian Kuhn uploaded patch set 27 07/19/21, 13:54
-
core-ci voted on patch set 27 V +1 07/19/21, 14:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13502
-
Jochen Roth voted on patch set 27 V +1 CR +1 07/19/21, 14:11
-
Christian Kuhn commented on patch set 27 07/19/21, 14:12
FormViewHelperTest.php:76ReplyDone -
Benni Mack voted on patch set 27 V +1 CR +1 07/19/21, 15:08
-
Christian Kuhn voted on patch set 27 V +2 CR +2 07/19/21, 15:28
-
Christian Kuhn merged patch set 28 07/19/21, 15:28
FormViewHelperTest.php:76