Review main Merged

69893[TASK] Clean up Permission controllers

Oli Bartsch CR +2 V +2 Expert +631 −662 updated 07/16/21, 13:53

Commit message

The PermissionController was previously handled
via extbase, even though no pure Extbase-related
feature (validation, type-converting, persistence)
was used. Furthermore a combination of non-extbase
arguments and extbase-prefixed arguments was used,
leading to a couple of GeneralUtility::_GP() usages.

To clean up the controller, it is now not longer
registered as extbase module, while keeping
the module name "system_BeuserTxPermission"
for backwards-compatibility reasons.

Furthermore, is the PermissionAjaxController,
used for inline updates in the tree view,
moved into the PermissionController. This
allowed to streamline and clean up its only
endpoint.

Besides the clean up, some things got improved,
e.g. the shortcut button does now also take the
current action into account and all used labels
can now be translated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 913

  1. Oli Bartsch uploaded patch set 1 07/15/21, 12:04

  2. core-ci voted on patch set 1 V -1 07/15/21, 12:16 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13353

  3. Oli Bartsch uploaded patch set 2 07/15/21, 15:59

  4. core-ci voted on patch set 2 V +1 07/15/21, 16:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13362

  5. Benni Mack uploaded patch set 3 07/16/21, 10:25

  6. core-ci voted on patch set 3 V +1 07/16/21, 10:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13382

  7. Benni Mack voted on patch set 3 V +1 CR +1 07/16/21, 12:15

  8. Jochen Roth uploaded patch set 4 07/16/21, 13:17

  9. Benni Mack voted on patch set 4 V +1 CR +1 07/16/21, 13:27

  10. core-ci voted on patch set 4 V +1 07/16/21, 13:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13390

  11. Jochen Roth voted on patch set 4 V +1 CR +1 07/16/21, 13:46

  12. Benni Mack voted on patch set 4 V +2 CR +2 07/16/21, 13:53

  13. Benni Mack merged patch set 5 07/16/21, 13:53