Review main Merged

69894[TASK] Skip SVG sanitizer test causing segmentation fault

Oliver Hader CR +2 V +2 Easy +4 −0 updated 07/16/21, 10:21

Commit message

SVG sanitizer test dataset entity.svg is causing segmentation fault
in certain scenarios - which might be related to libxml2 before
version 2.9.12. Unfortunately, investigations did not reveal any
further details other than libxml2.

As a result `entity.svg` test dataset, which is causing this problem is
skipped until https://github.com/darylldoyle/svg-sanitizer/pull/53 is
merged and released in the upstream library.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Markus Klein +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Oliver Hader uploaded patch set 1 07/15/21, 19:48

  2. core-ci voted on patch set 1 V -1 07/15/21, 19:52 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13367

  3. Oliver Hader uploaded patch set 2 07/15/21, 20:06

  4. Markus Klein voted on patch set 2 V +1 CR +1 07/15/21, 20:15

  5. core-ci voted on patch set 2 V +1 07/15/21, 20:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13369

  6. Oliver Hader voted on patch set 2 CR -1 07/15/21, 20:48

  7. Oliver Hader commented on patch set 2 07/15/21, 21:47

    → maybe not required anymore https://github.com/darylldoyle/svg-sanitizer/pull/53 → please test, whether the PR in the upstream repository fixes those segmentation fault issues
  8. Oliver Hader uploaded patch set 3 07/16/21, 09:52

  9. core-ci voted on patch set 3 V +1 07/16/21, 10:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13378

  10. Markus Klein voted on patch set 3 V +1 CR +1 07/16/21, 10:16

  11. Oliver Hader voted on patch set 3 V +2 CR +2 07/16/21, 10:21

  12. Oliver Hader merged patch set 4 07/16/21, 10:21