Review main Merged

69897[TASK] Remove empty h2 and margin in Scheduler module

Oli Bartsch CR +2 V +2 Easy +35 −13 updated 07/16/21, 13:53

Commit message

This patch removes an empty h2 tag in the scheduler
module and also removes an unnecessary margin-bottom
which visually looked like an empty table row.

Furthermore is the main template structure now also
rendered using the already existing standalone view
instance.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Oli Bartsch uploaded patch set 1 07/16/21, 11:15

  2. core-ci voted on patch set 1 V +1 07/16/21, 11:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13384

  3. Benni Mack voted on patch set 1 V +1 CR +1 07/16/21, 12:23

  4. Guido Schmechel voted on patch set 1 V +1 CR +1 07/16/21, 13:47

  5. Benni Mack voted on patch set 1 V +2 CR +2 07/16/21, 13:53

  6. Benni Mack merged patch set 2 07/16/21, 13:53