Review 10.4 Abandoned

69900[BUGFIX] No hrefLang if language enabled is false

Jonathan IROULIN CR 0 V 0 Easy +17 −2 updated 11/09/21, 19:33

Commit message

Check if language is enabled in config.yaml file.

If « enabled » attribute is missing or is « true », it generate hrefLang.
If « enabled » attribute is set to false, it don’t generate hrefLang.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 57

  1. Jonathan IROULIN uploaded patch set 1 07/16/21, 16:58

  2. core-ci voted on patch set 1 V +1 07/16/21, 17:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13399

  3. Oliver Klee commented on patch set 1 CR -1 07/16/21, 18:54

    You'll also need to change the target branch to master when pushing. (It currently is still 10.4 if I'm not mistaken.)
  4. Jonathan IROULIN uploaded patch set 2 07/19/21, 05:57

  5. core-ci voted on patch set 2 V +1 07/19/21, 06:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13468

  6. Christian Kuhn commented on patch set 2 11/09/21, 19:33

    Hey. I'll abandon the v10 version of this patch for now: We should align on a solution in master and while we're doing this, other branches will be sorted out.
  7. Christian Kuhn abandoned the change 11/09/21, 19:33