Review main Merged

69904[TASK] Testing type=group localizeReferencesAtParentLocalization

Nikita Hovratov CR +2 V +2 Hard +256 −0 updated 11/09/21, 21:01

Commit message

Add core and workspace functional test for TCA option
'localizeReferencesAtParentLocalization' with type=group
to nail current state.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 11

Review log 912

  1. Nikita Hovratov uploaded patch set 1 07/16/21, 19:09

  2. core-ci voted on patch set 1 V +1 07/16/21, 19:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13404

  3. Anja Leichsenring uploaded patch set 2 11/05/21, 12:33

  4. core-ci voted on patch set 2 V -1 11/05/21, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18950

  5. Christian Kuhn commented on patch set 2 CR -1 11/09/21, 18:14

    i'll finish this now.
  6. Christian Kuhn uploaded patch set 3 11/09/21, 18:46

  7. core-ci voted on patch set 3 V +1 11/09/21, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19081

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 11/09/21, 19:02

  9. Nikita Hovratov voted on patch set 3 V +1 CR +1 11/09/21, 19:38

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 11/09/21, 21:00

  11. Christian Kuhn commented on patch set 3 11/09/21, 21:01

    let's bring this testing change in to finally fix the main issue from 2013!
  12. Christian Kuhn merged patch set 4 11/09/21, 21:01