69907[FEATURE] Add new SMTP configuration settings
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Mail/TransportFactory.php+19 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+4 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+14 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-94544-AddNewSMTPConfigurationSettings.rstnew+56 −0
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.php+32 −0
Review log 1827
Show 2 earlier messages
-
core-ci voted on patch set 1 V -1 07/17/21, 10:02 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13413
-
core-ci voted on patch set 2 V -1 07/17/21, 10:06 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13415
-
Guido Schmechel uploaded patch set 3 07/17/21, 10:09
-
core-ci voted on patch set 3 V +1 07/17/21, 10:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13416
-
Guido Schmechel commented on patch set 3 V -1 07/17/21, 10:21
Waiting for a merged https://review.typo3.org/c/Packages/TYPO3.CMS/+/69652 and feedback in the ticket to clarify the infotext for the install tool for transport_smtp_stream_options. Other info texts were copied from the docblocks of the respective Symfony functions. -
Guido Schmechel uploaded patch set 4 11/14/21, 08:59
-
Guido Schmechel commented on patch set 4 V -1 11/14/21, 09:00
Just a rebase -
core-ci voted on patch set 4 V +1 11/14/21, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19256
-
Guido Schmechel uploaded patch set 5 11/14/21, 13:25
-
core-ci voted on patch set 5 V +1 11/14/21, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19269
-
Guido Schmechel commented on patch set 5 11/14/21, 13:44
To clarify: - Description for "transport_smtp_stream_options": Maybe someone has more info on these options. There seems to be no official documentation on this? At least I can't find anything suitable for the user. - A decision is needed on whether it will be added as a feature in v12 or like https://review.typo3.org/c/Packages/TYPO3.CMS/+/69652 as a "task" in v11 and v12 Otherwise, however, you can already test this. And important: The array options for StreamOptions must of course be in the AdditionalConfig, because we don't have a UI solution for this. Comparable to [HTTP][proxy] -
Benni Mack wrote 11/29/21, 10:13
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 6 11/29/21, 13:38
-
core-ci voted on patch set 6 V +1 11/29/21, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20061
-
Christian Weiske commented on patch set 6 V +1 12/06/21, 09:01
We've ported this patch to TYPO3v10 and it works fine. (We have a mail server that offers - but not requires - STARTTLS for mail sending, and only has an automatically generated dummy ssl certificate.) -
Stefan Bürk uploaded patch set 7 12/06/21, 11:41
-
Stefan Bürk commented on patch set 7 CR -1 12/06/21, 11:50
Thanks for the patch, just moved the rst-file. Temporarly -1, will look into it and play around with it and do some broader verifications. -
core-ci voted on patch set 7 V +1 12/06/21, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20628
-
Stefan Bürk uploaded patch set 8 12/19/21, 19:53
-
Stefan Bürk updated the commit message in patch set 9 12/19/21, 20:05
-
core-ci voted on patch set 8 V +1 12/19/21, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21259
-
Stefan Bürk commented on patch set 9 V +1 CR +1 12/19/21, 20:09
Again, thanks for this feature Guido, and take my apology for the long -1, but I needed some time for the extensive tests. General notes for others: I have verified this extensivly, playing around with different possible stream context options. Especially for the ssl-verify I have setup different mail MTA's, with different configurations, with real ssl certificates but also self-signed. Futhermore I tested it against several well known mail hosting services. This took quite some time. This includes test for the threshold options (which was quite nasty to simulate from the MTA side). -
core-ci voted on patch set 9 V +1 12/19/21, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21260
-
Benni Mack voted on patch set 9 V +2 CR +2 12/23/21, 14:59
-
Benni Mack merged patch set 10 12/23/21, 14:59