Review main Merged

6991[BUGFIX][reports] Missing check for SOAP extension

Mario Rimann CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Add SOAP PHP-Module to the list of required modules to be checked in the
reports module.

Review

  • Code review CR +2
    • Steffen Gebert +2
  • Verified V +2
    • Steffen Gebert +2

Issues 1

Files 1

Review log 10

  1. Mario Rimann commented on patch set 1 12/17/11, 10:56

    Stefan: I oriented myself on the bug report, which states that this error appeared in 4.5 - not sure if that's true.
  2. Stefan Neufeind commented on patch set 1 12/17/11, 10:56

    Imho it was only 4.6 when we started requiring (hard requirement) the SOAP-extension. So if I'm right the releases-line would need adjustment. Apart from that I agree with the patch. http://wiki.typo3.org/TYPO3_4.6 http://wiki.typo3.org/TYPO3_4.5
  3. Steffen Gebert uploaded patch set 2 12/17/11, 10:56

  4. Steffen Gebert uploaded patch set 3 12/17/11, 10:56

  5. Steffen Gebert commented on patch set 3 V 0 12/17/11, 10:56

    by team member; Looks good to me, approved Thanks for pushing it forward, Mario! Yes, indeed this error also occurs in 4.5, where soap hasn't been a requirement. Therefore I would not introduce this change there, as the extension key handling is really an edge use-case. I would say most developers will not do such things with 4.5. No-brainer for 4.7 and 4.6
  6. Steffen Gebert merged patch set 3 12/17/11, 10:56

  7. Simon Schaufelberger commented on patch set 1 12/17/11, 10:56

    Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 12/17/11, 10:56

  9. Mr. Jenkins commented on patch set 2 12/17/11, 10:56

  10. Mr. Jenkins commented on patch set 3 12/17/11, 10:56