6991[BUGFIX][reports] Missing check for SOAP extension
Commit message
Review
-
Code review CR +2
- Steffen Gebert +2
-
Verified V +2
- Steffen Gebert +2
Issues 1
Files 1
Review log 10
-
Mario Rimann commented on patch set 1 12/17/11, 10:56
Stefan: I oriented myself on the bug report, which states that this error appeared in 4.5 - not sure if that's true. -
Stefan Neufeind commented on patch set 1 12/17/11, 10:56
Imho it was only 4.6 when we started requiring (hard requirement) the SOAP-extension. So if I'm right the releases-line would need adjustment. Apart from that I agree with the patch. http://wiki.typo3.org/TYPO3_4.6 http://wiki.typo3.org/TYPO3_4.5 -
Steffen Gebert uploaded patch set 2 12/17/11, 10:56
-
Steffen Gebert uploaded patch set 3 12/17/11, 10:56
-
Steffen Gebert commented on patch set 3 V 0 12/17/11, 10:56
by team member; Looks good to me, approved Thanks for pushing it forward, Mario! Yes, indeed this error also occurs in 4.5, where soap hasn't been a requirement. Therefore I would not introduce this change there, as the extension key handling is really an edge use-case. I would say most developers will not do such things with 4.5. No-brainer for 4.7 and 4.6 -
Steffen Gebert merged patch set 3 12/17/11, 10:56
-
Simon Schaufelberger commented on patch set 1 12/17/11, 10:56
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 12/17/11, 10:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2555/ : SUCCESS -
Mr. Jenkins commented on patch set 2 12/17/11, 10:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2774/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/17/11, 10:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2775/ : SUCCESS