Review main Merged

69911[BUGFIX] Add missing title tag for edit icon in page module.

Georg Ringer CR +2 V +2 Easy +1 −1 updated 07/21/21, 09:26

Commit message

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Guido Schmechel +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Georg Ringer uploaded patch set 1 07/18/21, 06:45

  2. Georg Ringer commented on patch set 1 07/18/21, 06:45

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 07/18/21, 06:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13426

  4. Lina Wolf commented on patch set 1 CR +1 07/18/21, 07:58

    Code looks good
  5. Lina Wolf commented on patch set 1 V +1 07/18/21, 08:18

    And also it works
  6. Guido Schmechel commented on patch set 1 V +1 CR +1 07/18/21, 11:12

    I am lazy. Can we also correct "Unhide" here or do we necessarily need a new issue? Affected place: typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php getVisibilityToggleTitle (unhide to unHide)
  7. Oliver Klee voted on patch set 1 CR +1 07/18/21, 11:58

  8. Helmut Hummel voted on patch set 1 V +1 CR +1 07/21/21, 09:17

  9. Lina Wolf voted on patch set 1 V +2 CR +2 07/21/21, 09:20

  10. Lina Wolf merged patch set 2 07/21/21, 09:26