69914[FEATURE] Clear indexed_search documents when content is changed
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
- kharaf +1
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- kharaf +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/master/Feature-94577-ClearIndexed_searchDocumentsWhenContentIsChanged.rstnew+28 −0
- typo3/sysext/indexed_search/Classes/Domain/Repository/AdministrationRepository.php+100 −83
- typo3/sysext/indexed_search/Classes/Hook/DeleteIndexedData.php2new+50 −0
- typo3/sysext/indexed_search/Resources/Private/Language/locallang_em.xlf+3 −0
- typo3/sysext/indexed_search/ext_conf_template.txt+3 −0
- typo3/sysext/indexed_search/ext_localconf.php+1 −0
Review log 1623
-
Georg Ringer uploaded patch set 1 07/18/21, 09:38
-
core-ci voted on patch set 1 V -1 07/18/21, 09:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13429
-
Georg Ringer uploaded patch set 2 07/18/21, 10:21
-
core-ci voted on patch set 2 V -1 07/18/21, 10:34 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13430
-
Georg Ringer rebased onto patch set 3 07/22/21, 09:37
-
core-ci voted on patch set 3 V -1 07/22/21, 09:48 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13649
-
Georg Ringer uploaded patch set 4 07/27/21, 17:05
-
core-ci voted on patch set 4 V -1 07/27/21, 17:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13820
-
Georg Ringer uploaded patch set 5 07/28/21, 10:50
-
core-ci voted on patch set 5 V -1 07/28/21, 10:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13837
-
Georg Ringer uploaded patch set 6 07/28/21, 11:46
-
core-ci voted on patch set 6 V +1 07/28/21, 12:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13840
-
Georg Ringer commented on patch set 6 07/28/21, 15:51
This change is ready for review. -
Benni Mack commented on patch set 6 07/29/21, 11:34
DeleteIndexedData.php:36if we manage to use extGetTreeList for removeIndexedPhashRow() - which is more performant than getPageTree(), then we do not need to modify the AbstractTreeView in this change -
Christian Kuhn commented on patch set 6 CR -1 07/29/21, 20:10
AbstractTreeView.php:184this looks quite unrelated & bogus. why do you need this? is this a separate bug fix or a wrong usage in your patch or something? -
Georg Ringer commented on patch set 6 07/30/21, 18:05
AbstractTreeView.php:184Replycheck the failing tests in the beginning. the treeview is used to get a recursive pidlist in the indexed_search repository -
Benni Mack uploaded patch set 7 08/02/21, 06:46
-
core-ci voted on patch set 7 V +1 08/02/21, 07:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13973
-
kharaf commented on patch set 7 V +1 CR +1 08/12/21, 12:18
Testing this path in my local typo3 11.4.0-dev, everthing is ok. -
Tymoteusz Motylewski voted on patch set 7 V +2 CR +2 08/14/21, 09:50
-
Tymoteusz Motylewski voted on patch set 7 V 0 CR 0 08/14/21, 09:52
-
Tymoteusz Motylewski commented on patch set 7 V +2 CR +2 08/14/21, 10:02
AbstractTreeView.php:184Replylooks it's resolved in patchest 7DeleteIndexedData.php:36Replylooks it's resolved in patchest 7 -
Tymoteusz Motylewski merged patch set 8 08/14/21, 10:02