Review main Merged

69914[FEATURE] Clear indexed_search documents when content is changed

Georg Ringer CR +2 V +2 Hard +185 −83 updated 08/14/21, 10:02

Commit message

A new feature flag enables indexed_search to remove the documents from
the index if the page or content is changed in the backend.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • kharaf +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • kharaf +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1623

  1. Georg Ringer uploaded patch set 1 07/18/21, 09:38

  2. core-ci voted on patch set 1 V -1 07/18/21, 09:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13429

  3. Georg Ringer uploaded patch set 2 07/18/21, 10:21

  4. core-ci voted on patch set 2 V -1 07/18/21, 10:34 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13430

  5. Georg Ringer rebased onto patch set 3 07/22/21, 09:37

  6. core-ci voted on patch set 3 V -1 07/22/21, 09:48 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13649

  7. Georg Ringer uploaded patch set 4 07/27/21, 17:05

  8. core-ci voted on patch set 4 V -1 07/27/21, 17:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13820

  9. Georg Ringer uploaded patch set 5 07/28/21, 10:50

  10. core-ci voted on patch set 5 V -1 07/28/21, 10:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13837

  11. Georg Ringer uploaded patch set 6 07/28/21, 11:46

  12. core-ci voted on patch set 6 V +1 07/28/21, 12:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13840

  13. Georg Ringer commented on patch set 6 07/28/21, 15:51

    This change is ready for review.
  14. Benni Mack commented on patch set 6 07/29/21, 11:34

    DeleteIndexedData.php:36

    if we manage to use extGetTreeList for removeIndexedPhashRow() - which is more performant than getPageTree(), then we do not need to modify the AbstractTreeView in this change
  15. Christian Kuhn commented on patch set 6 CR -1 07/29/21, 20:10

    AbstractTreeView.php:184

    this looks quite unrelated & bogus. why do you need this? is this a separate bug fix or a wrong usage in your patch or something?
  16. Georg Ringer commented on patch set 6 07/30/21, 18:05

    AbstractTreeView.php:184 Reply

    check the failing tests in the beginning. the treeview is used to get a recursive pidlist in the indexed_search repository
  17. Benni Mack uploaded patch set 7 08/02/21, 06:46

  18. core-ci voted on patch set 7 V +1 08/02/21, 07:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13973

  19. kharaf commented on patch set 7 V +1 CR +1 08/12/21, 12:18

    Testing this path in my local typo3 11.4.0-dev, everthing is ok.
  20. Tymoteusz Motylewski voted on patch set 7 V +2 CR +2 08/14/21, 09:50

  21. Tymoteusz Motylewski voted on patch set 7 V 0 CR 0 08/14/21, 09:52

  22. Tymoteusz Motylewski commented on patch set 7 V +2 CR +2 08/14/21, 10:02

    AbstractTreeView.php:184 Reply

    looks it's resolved in patchest 7

    DeleteIndexedData.php:36 Reply

    looks it's resolved in patchest 7
  23. Tymoteusz Motylewski merged patch set 8 08/14/21, 10:02