Review main Merged

69916[TASK] Reduce usages of GeneralUtility::linkThisScript and use proper routing

Benni Mack CR +2 V +2 Normal +45 −36 updated 08/03/21, 09:31

Commit message

This change replaces some of the linkThisScript calls
to use the UriBuilder / Routing of TYPO3 Backend,
and corrects existing UriBuilder calls.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1015

  1. Benni Mack uploaded patch set 1 07/18/21, 15:10

  2. core-ci voted on patch set 1 V +1 07/18/21, 15:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13446

  3. Benni Mack uploaded patch set 2 07/20/21, 15:13

  4. core-ci voted on patch set 2 V -1 07/20/21, 15:25 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13607

  5. Benni Mack uploaded patch set 3 07/28/21, 19:45

  6. core-ci voted on patch set 3 V +1 07/28/21, 19:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13860

  7. Benni Mack updated the commit message in patch set 4 07/29/21, 11:20

  8. core-ci voted on patch set 4 V +1 07/29/21, 11:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13872

  9. Oli Bartsch commented on patch set 4 08/02/21, 10:47

    RecordListController.php:526 Unresolved

    This leads to a SQL error due to double encoding.
  10. Oli Bartsch uploaded patch set 5 08/02/21, 10:49

  11. Oli Bartsch voted on patch set 5 V +1 CR +1 08/02/21, 10:49

  12. core-ci voted on patch set 5 V +1 08/02/21, 11:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13982

  13. Jochen Roth voted on patch set 5 V +1 CR +1 08/03/21, 08:34

  14. Benni Mack voted on patch set 5 V +2 CR +2 08/03/21, 09:31

  15. Benni Mack merged patch set 6 08/03/21, 09:31