Review main Merged

69917[TASK] Replace fetchColumn with fetchOne for Doctrine DBAL

Benni Mack CR +2 V +2 Hard +173 −166 updated 07/22/21, 10:18

Commit message

This change replaces all query results from the
database from fetchColumn() to fetchOne(), as this
is the new API used in Doctrine DBAL.

This change is one of a few to prepare for
Doctrine DBAL 3.0 compatibility.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 89

Show 69 more files

Review log 712

  1. Benni Mack uploaded patch set 1 07/18/21, 15:26

  2. core-ci voted on patch set 1 V -1 07/18/21, 15:37 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13447

  3. Benni Mack uploaded patch set 2 07/18/21, 16:23

  4. core-ci voted on patch set 2 V -1 07/18/21, 16:36 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13451

  5. Benni Mack uploaded patch set 3 07/20/21, 15:38

  6. core-ci voted on patch set 3 V +1 07/20/21, 15:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13608

  7. Benni Mack updated the commit message in patch set 4 07/21/21, 07:27

  8. core-ci voted on patch set 4 V +1 07/21/21, 07:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13617

  9. core-ci commented on patch set 4 07/21/21, 11:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13619

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 07/21/21, 17:04

  11. Oli Bartsch voted on patch set 4 V +2 CR +2 07/22/21, 10:18

  12. Oli Bartsch merged patch set 5 07/22/21, 10:18