69920[BUGFIX] No hrefLang if language enabled is false
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
Review log 2026
Show 1 earlier messages
-
Jonathan IROULIN uploaded patch set 1 07/19/21, 06:06
-
core-ci voted on patch set 1 V +1 07/19/21, 06:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13469
-
Benni Mack updated the commit message in patch set 2 11/18/21, 10:40
-
core-ci voted on patch set 2 V +1 11/18/21, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19451
-
Benni Mack wrote 11/29/21, 10:16
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 3 11/29/21, 14:02
-
core-ci voted on patch set 3 V +1 11/29/21, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20072
-
Benni Mack uploaded patch set 4 12/13/21, 12:14
-
Benni Mack commented on patch set 4 12/13/21, 12:16
Also check https://review.typo3.org/c/Packages/TYPO3.CMS/+/69919 which contains tests -
core-ci voted on patch set 4 V +1 12/13/21, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21025
-
Benni Mack commented on patch set 4 V -1 12/13/21, 23:03
Hey Jonathan, I can't reproduce this issue anymore with TYPO3 v11.5.3. I even wrote tests to check this, but they still work properly. -
Stefan Bürk commented on patch set 4 12/14/21, 02:44
Reply
I can reproduce this with 11.5 branch (introduction package installed), and also that this patch "seems" to fix this issue (in a quick review). Anyway, I'm to stupid to reproduce this on main, with styleguide, but I do not get a hreflang menu at all there. This patch do not includes tests for it, so hard to say if they would run. May you share the tests you wrote ?? -
Benni Mack uploaded patch set 5 12/14/21, 08:36
-
core-ci voted on patch set 5 V -1 12/14/21, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21065
-
Stefan Bürk commented on patch set 5 12/14/21, 08:52
Will push fixed test-case.HrefLangGeneratorTest.php:128That's the wrong way round. Language "ES" is disabled for the frontend, so this should "not be there". This tests the old / broken behaviour now, thus failing this patch which fixes this issue. This line should be remove, thus green with this patch/fix. Without "red" (and others). In the end the provided test verifies that this issues exists and get fixed with this patch. -
Benni Mack commented on patch set 5 12/14/21, 08:53
HrefLangGeneratorTest.php:128ReplyI know. This was my test to have a new language enabled but did not show an entry. This test is actually only half-good. It tests IF something is shown but not if something is NOT shown. -
Stefan Bürk commented on patch set 5 12/14/21, 08:58
HrefLangGeneratorTest.php:128ReplyI see. We need a better testing here so we can say "this should not be there" to be green. Right ? -
Stefan Bürk uploaded patch set 6 12/14/21, 09:07
-
Stefan Bürk commented on patch set 6 12/14/21, 09:08
HrefLangGeneratorTest.php:128Replythe next subarray checks for "not expect to be there" ... moving the es one array down would exactly check this to be not there. Or am I missing still something ? -
core-ci voted on patch set 6 V +1 12/14/21, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21069
-
Benni Mack commented on patch set 6 12/14/21, 09:24
HrefLangGeneratorTest.php:128Replyexactly! -
Stefan Bürk commented on patch set 6 V -1 CR -1 12/15/21, 05:13
This patch is not needed anymore. At first the code look's like it is correct and make sense, which is does if viewed in that place. Thus this lead to some confusings. Fact is, that this issue is not reproduciable, and that disabling a language for the frontend in site configuration would not render that language as href-lang entry. HrefLangGenerator uses the LanguageMenuProcessor under the hood, which got some love and a fix to check for language available in frontend with: https://review.typo3.org/c/Packages/TYPO3.CMS/+/57934/ I would say that this has solved this issue already, but not played around or reverted it. Could not verify the issue in 10.4, 11.5 or main(12.0-dev), and as such not the fix. So I would suggest to abandon this long standing patch, as the issue was fixed in the mean-time already. -
Stefan Bürk commented on patch set 6 12/15/21, 05:14
HrefLangGeneratorTest.php:128ReplyDone -
Stefan Bürk commented on patch set 6 12/15/21, 05:14
Reply
Done -
Benni Mack wrote 12/22/21, 15:49
Removed reviewer Benni Mack. -
Benni Mack abandoned the change 12/23/21, 12:38
will abandon this change for the time being, can be restored again once this topic comes up again