Review main Merged

69922[BUGFIX] Fix sphinx warnings in previous changelog entries

Lina Wolf CR +2 V +2 Hard +234 −231 updated 07/29/21, 20:03

Commit message

Fixes Layout problems: Malformed lists, malformed
headlines, non-working links to documentation or
other changelogs.
Directive `:ts:` and `.. code-block:: ts` is only
used for typescript, exchanged it into `:typoscript:`
for typoscript examples.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 58

Show 38 more files

Review log 2538

Show 913 earlier messages
  1. Lina Wolf uploaded patch set 1 07/19/21, 07:39

  2. core-ci voted on patch set 1 V +1 07/19/21, 07:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13472

  3. Christian Kuhn commented on patch set 1 CR -1 07/19/21, 08:43

    should have backports to v10 and maybe even v9
  4. Lina Wolf updated the commit message in patch set 2 07/19/21, 11:38

  5. core-ci voted on patch set 2 V +1 07/19/21, 11:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13488

  6. Simon Gilli commented on patch set 2 CR -1 07/19/21, 11:57

    Found still some minor issues, primary with the indention

    Feature-88318-DisplayApplicationContextInCLI.rst:19

    wrong indention, should be 3 spaces

    Feature-91080-SiteSettingsAsTsConstantsAndInTsConfig.rst:32

    Correct indention for yaml is 2 spaces, not sure why you have to change it. If someone copies this code he will endup with wrong indention.

    Deprecation-62855-XHTMLCleaningMovedToLegacyExtension.rst:20

    wrong indent, tab instead of spaces

    Deprecation-62855-XHTMLCleaningMovedToLegacyExtension.rst:26

    wrong indent, tab instead of spaces

    Breaking-65962-WebSVGLibraryAndAPIRemoved.rst:30

    wrong indent, tab instead of spaces. same below and above.

    Deprecation-65934-PrefixLocalAnchorsMovedToLegacyExtension.rst:21

    wrong indent, tab instead of spaces

    Deprecation-65934-PrefixLocalAnchorsMovedToLegacyExtension.rst:27

    wrong indent, tab instead of spaces

    Deprecation-15415-DeprecateRemoveBadHTML.rst:15

    wrong indent, one space missing

    Deprecation-76383-DeprecateFontTag.rst:15

    wrong indent, one missing space

    Deprecation-78217-FramesetAndFrame.rst:17

    wrong indent, one missing space

    Deprecation-78217-FramesetAndFrame.rst:22

    wrong indent, one missing space

    Important-88302-PreventOverridingCKEditorConfigFromPlugins.rst:44

    wrong indent, 3 spaces instead of 2

    Deprecation-79858-TSFE-relatedPropertiesAndMethods.rst:14

    wrong indent, one missing space

    Deprecation-79858-TSFE-relatedPropertiesAndMethods.rst:20

    wrong indent, one missing space

    Deprecation-79858-TSFE-relatedPropertiesAndMethods.rst:27

    wrong indent, one missing space

    Breaking-82878-RemovedFieldNoCacheInDatabaseTablePages.rst:45 Unresolved

    wrong indent, one missing space

    Breaking-82919-RemovedPageTreeRelatesTsConfigSettings.rst:14

    wrong indent, one missing space

    Feature-76459-AddCrossoriginPropertyToJavaScriptFiles.rst:22

    wrong indent, one missing space

    Feature-81223-IncludeCSSinlineProperty.rst:23

    wrong indent, tabs instead of spaces

    Feature-84749-HideDuplicateButtonByDefault.rst:14

    wrong indent, one missing space
  7. Lina Wolf commented on patch set 2 07/19/21, 12:32

    Reply

    Ok done

    Reply

    Could you maybe provide a patchset for these changes?

    Feature-91080-SiteSettingsAsTsConstantsAndInTsConfig.rst:32 Reply

    There where non-breaking changes here before that broke in rendering. General rule is that code-examples should have an indentation of 3 in the documentation. Do we have a special rule for YAML code examples I wonder?
  8. Lina Wolf uploaded patch set 3 07/20/21, 07:22

  9. Lina Wolf commented on patch set 3 07/20/21, 07:22

    Reply

    Done

    Feature-88318-DisplayApplicationContextInCLI.rst:19 Reply

    Done

    Feature-91080-SiteSettingsAsTsConstantsAndInTsConfig.rst:32 Reply

    Done

    Deprecation-62855-XHTMLCleaningMovedToLegacyExtension.rst:20 Reply

    Done

    Deprecation-62855-XHTMLCleaningMovedToLegacyExtension.rst:26 Reply

    Done

    Breaking-65962-WebSVGLibraryAndAPIRemoved.rst:30 Reply

    Done

    Deprecation-65934-PrefixLocalAnchorsMovedToLegacyExtension.rst:21 Reply

    Done

    Deprecation-65934-PrefixLocalAnchorsMovedToLegacyExtension.rst:27 Reply

    Done

    Deprecation-15415-DeprecateRemoveBadHTML.rst:15 Reply

    Done

    Deprecation-76383-DeprecateFontTag.rst:15 Reply

    Done

    Deprecation-78217-FramesetAndFrame.rst:17 Reply

    Done

    Deprecation-78217-FramesetAndFrame.rst:22 Reply

    Done

    Important-88302-PreventOverridingCKEditorConfigFromPlugins.rst:44 Reply

    Done

    Deprecation-79858-TSFE-relatedPropertiesAndMethods.rst:14 Reply

    Done

    Deprecation-79858-TSFE-relatedPropertiesAndMethods.rst:20 Reply

    Done

    Deprecation-79858-TSFE-relatedPropertiesAndMethods.rst:27 Reply

    Done

    Breaking-82919-RemovedPageTreeRelatesTsConfigSettings.rst:14 Reply

    Done

    Feature-76459-AddCrossoriginPropertyToJavaScriptFiles.rst:22 Reply

    Done

    Feature-81223-IncludeCSSinlineProperty.rst:23 Reply

    Done

    Feature-84749-HideDuplicateButtonByDefault.rst:14 Reply

    Done
  10. core-ci voted on patch set 3 V +1 07/20/21, 07:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13536

  11. Simon Gilli commented on patch set 3 CR -1 07/26/21, 10:31

    still some minor issues, some suggestions are not mandatory like on the last review

    Feature-90213-SupportBitAndInTypoScriptStdWrapIf.rst:28 Unresolved

    The default indention for TypoScript is 2 spaces see https://github.com/TYPO3/TYPO3.CMS/blob/master/.editorconfig#L38

    Feature-91132-IntroduceUserSettingsJavaScriptModulesEvent.rst:78 Unresolved

    Other files using `*` here

    Breaking-93023-ReworkedSessionHandling.rst:151 Unresolved

    Other files using `*` here, well both should work. So just ignore if you think it's fine.

    Deprecation-15415-DeprecateRemoveBadHTML.rst:14 Unresolved

    maybe use `*` here

    Deprecation-76383-DeprecateFontTag.rst:15 Unresolved

    Maybe format as list?

    Important-88302-PreventOverridingCKEditorConfigFromPlugins.rst:22 Unresolved

    one space is missing

    Important-88302-PreventOverridingCKEditorConfigFromPlugins.rst:43 Unresolved

    one space is missing

    Breaking-82919-RemovedPageTreeRelatesTsConfigSettings.rst:14 Unresolved

    maybe use `*` here

    Feature-84749-HideDuplicateButtonByDefault.rst:14 Unresolved

    maybe use `*` here
  12. Lina Wolf rebased onto patch set 4 07/26/21, 11:01

  13. core-ci voted on patch set 4 V +1 07/26/21, 11:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13750

  1. Simon Gilli commented on patch set 5 07/26/21, 11:32

    Published edit on patch set 4.
  2. Simon Gilli commented on patch set 6 07/26/21, 11:33

    Published edit on patch set 5.
  3. Simon Gilli commented on patch set 7 07/26/21, 11:34

    Published edit on patch set 6.
  4. Simon Gilli commented on patch set 8 07/26/21, 11:36

    Published edit on patch set 7.
  5. Simon Gilli commented on patch set 9 07/26/21, 11:37

    Published edit on patch set 8.
  6. Simon Gilli commented on patch set 10 07/26/21, 11:38

    Published edit on patch set 9.
  7. Simon Gilli commented on patch set 11 07/26/21, 11:39

    Published edit on patch set 10.
  8. Simon Gilli commented on patch set 12 07/26/21, 11:39

    Published edit on patch set 11.
  9. Simon Gilli voted on patch set 12 V +1 CR +1 07/26/21, 11:40

  10. core-ci voted on patch set 6 V +1 07/26/21, 11:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13752

  11. core-ci voted on patch set 7 V +1 07/26/21, 11:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13753

  12. core-ci voted on patch set 5 V +1 07/26/21, 11:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13751

  13. core-ci voted on patch set 8 V +1 07/26/21, 11:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13754

  14. core-ci voted on patch set 10 V +1 07/26/21, 11:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13756

  15. core-ci voted on patch set 9 V +1 07/26/21, 12:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13755

  16. core-ci voted on patch set 11 V +1 07/26/21, 12:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13757

  17. core-ci voted on patch set 12 V +1 07/26/21, 12:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13758

  18. Nikita Hovratov commented on patch set 12 07/26/21, 17:21

    Feature-90522-IntroduceAssetCollector.rst:20

    I think the author referred to the internal php variable here, as the API can also be used outside of fluid. So I suggest changing it back to php here.
  19. Christian Kuhn commented on patch set 12 CR -1 07/29/21, 17:13

    working on pre-patches so the backports are smooth.
  20. Christian Kuhn uploaded patch set 13 07/29/21, 19:33

  21. Christian Kuhn commented on patch set 13 V +1 CR +1 07/29/21, 19:33

    Feature-90522-IntroduceAssetCollector.rst:20 Reply

    Done
  22. Simon Gilli voted on patch set 13 V +1 CR +1 07/29/21, 19:35

  23. core-ci voted on patch set 13 V +1 07/29/21, 19:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13898

  24. Christian Kuhn voted on patch set 13 V +2 CR +2 07/29/21, 20:03

  25. Christian Kuhn merged patch set 14 07/29/21, 20:03