Review main Merged

69959[BUGFIX] Check whether tt_content parent page is accessible

Oli Bartsch CR +2 V +2 Easy +34 −5 updated 07/20/21, 21:33

Commit message

Both, DatabaseRecordList as well as the ContextMenu feature the
"Show" button to preview a content element on its parent page.
However, in case the parent page is a "no view doktype" (e.g. sys
folder), those buttons lead to a 404 error.

This is now fixed by properly checking whether a content elements'
parent page can be viewed. If not, the button is no longer shown.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Oli Bartsch uploaded patch set 1 07/19/21, 15:28

  2. core-ci voted on patch set 1 V -1 07/19/21, 15:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13508

  3. Oli Bartsch uploaded patch set 2 07/19/21, 15:34

  4. core-ci voted on patch set 2 V +1 07/19/21, 15:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13509

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 07/19/21, 18:36

  6. Benni Mack voted on patch set 2 V +1 CR +1 07/20/21, 14:37

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 07/20/21, 21:33

  8. Oli Bartsch merged patch set 3 07/20/21, 21:33