Review main Merged

69962[BUGFIX] Properly mark QueryView as deprecated

Christian Kuhn CR +2 V +2 Normal +77 −123 updated 07/22/21, 14:51

Commit message

The class logs a deprecation in __construct(),
but the @deprecated annotation is missing.

Unit and functional tests of QueryGenerator are
moved now and a PHP8 related patch that has been
done to core QueryGenerator is now merged into
lowlevel QueryGenerator, too.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 2030

Show 35 earlier messages
  1. Christian Kuhn uploaded patch set 1 07/19/21, 16:49

  2. Christian Kuhn updated the commit message in patch set 2 07/19/21, 16:49

  3. Oli Bartsch commented on patch set 2 07/19/21, 16:56

    QueryView.php:41

    Shouldn't we also add this annotation in QueryGenerator?

    QueryView.php:108

    This looks wrong.
  4. core-ci voted on patch set 2 V +1 07/19/21, 17:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13513

  5. core-ci voted on patch set 1 V +1 07/19/21, 17:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13512

  1. Christian Kuhn commented on patch set 2 07/19/21, 17:29

    QueryView.php:41 Reply

    QueryGenerator has it, was added later with other patch.

    QueryView.php:108 Reply

    nice. thx. seems i was a copy & paste and rush of shit into brain victim when i created the initial patch ;)
  2. Christian Kuhn uploaded patch set 3 07/19/21, 17:32

  3. core-ci voted on patch set 3 V +1 07/19/21, 17:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13514

  4. Christian Kuhn uploaded patch set 4 07/19/21, 18:29

  5. Christian Kuhn commented on patch set 4 07/19/21, 18:40

    QueryView.php:41 Reply

    Done

    QueryView.php:108 Reply

    Done
  6. core-ci voted on patch set 4 V -1 07/19/21, 18:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13520

  7. Christian Kuhn uploaded patch set 5 07/19/21, 19:15

  8. core-ci voted on patch set 5 V +1 07/19/21, 19:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13523

  9. Oli Bartsch voted on patch set 5 V +1 CR +1 07/19/21, 19:31

  10. Alexander Nitsche commented on patch set 5 CR -1 07/20/21, 14:19

    Taking the files of #65457 and #69962 into account, i would additionally adapt: 1. typo3/sysext/core/Classes/Database/QueryGenerator.php: add @deprecated annotation to class too 2. typo3/sysext/core/Tests/Functional/Database/QueryGeneratorTest.php: the FQCN of QueryGenerator has changed here too like in typo3/sysext/core/Tests/Unit/Database/QueryGeneratorTest.php
  11. Christian Kuhn uploaded patch set 6 07/22/21, 09:37

  12. Christian Kuhn commented on patch set 6 07/22/21, 09:39

    Reply

    1. this has been done already. 2. well, ok ... ;)
  13. core-ci voted on patch set 6 V -1 07/22/21, 09:40 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13650

  14. Christian Kuhn uploaded patch set 7 07/22/21, 09:46

  15. core-ci voted on patch set 7 V -1 07/22/21, 10:02 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13654

  16. Christian Kuhn uploaded patch set 8 07/22/21, 10:32

  17. Christian Kuhn updated the commit message in patch set 9 07/22/21, 10:33

  18. core-ci voted on patch set 8 V -1 07/22/21, 10:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13661

  19. core-ci voted on patch set 9 V -1 07/22/21, 10:51 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13662

  20. Christian Kuhn uploaded patch set 10 07/22/21, 11:15

  21. core-ci voted on patch set 10 V +1 07/22/21, 11:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13663

  22. Benni Mack voted on patch set 10 V +1 CR +1 07/22/21, 13:20

  23. Jochen Roth voted on patch set 10 V +1 CR +1 07/22/21, 14:48

  24. Christian Kuhn voted on patch set 10 V +2 CR +2 07/22/21, 14:50

  25. Christian Kuhn merged patch set 11 07/22/21, 14:51