69962[BUGFIX] Properly mark QueryView as deprecated
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 7
- typo3/sysext/core/Classes/Database/QueryGenerator.php+1 −1
- typo3/sysext/core/Classes/Database/QueryView.php6+3 −1
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+22 −29
- typo3/sysext/lowlevel/Tests/Functional/Database/Fixtures/TestGetPageTreeBranchedTreeSet.csvrenamed+0 −0
- typo3/sysext/lowlevel/Tests/Functional/Database/Fixtures/TestGetPageTreeStraightTreeSet.csvrenamed+0 −0
- typo3/sysext/lowlevel/Tests/Functional/Database/QueryGeneratorTest.phprenamed+47 −86
- typo3/sysext/lowlevel/Tests/Unit/Database/QueryGeneratorTest.phprenamed+4 −6
Review log 2030
Show 35 earlier messages
-
Christian Kuhn uploaded patch set 1 07/19/21, 16:49
-
Christian Kuhn updated the commit message in patch set 2 07/19/21, 16:49
-
Oli Bartsch commented on patch set 2 07/19/21, 16:56
QueryView.php:108This looks wrong. -
core-ci voted on patch set 2 V +1 07/19/21, 17:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13513
-
core-ci voted on patch set 1 V +1 07/19/21, 17:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13512
-
Christian Kuhn commented on patch set 2 07/19/21, 17:29
QueryView.php:41ReplyQueryGenerator has it, was added later with other patch.QueryView.php:108Replynice. thx. seems i was a copy & paste and rush of shit into brain victim when i created the initial patch ;) -
Christian Kuhn uploaded patch set 3 07/19/21, 17:32
-
core-ci voted on patch set 3 V +1 07/19/21, 17:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13514
-
Christian Kuhn uploaded patch set 4 07/19/21, 18:29
-
Christian Kuhn commented on patch set 4 07/19/21, 18:40
QueryView.php:41ReplyDoneQueryView.php:108ReplyDone -
core-ci voted on patch set 4 V -1 07/19/21, 18:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13520
-
Christian Kuhn uploaded patch set 5 07/19/21, 19:15
-
core-ci voted on patch set 5 V +1 07/19/21, 19:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13523
-
Oli Bartsch voted on patch set 5 V +1 CR +1 07/19/21, 19:31
-
Alexander Nitsche commented on patch set 5 CR -1 07/20/21, 14:19
Taking the files of #65457 and #69962 into account, i would additionally adapt: 1. typo3/sysext/core/Classes/Database/QueryGenerator.php: add @deprecated annotation to class too 2. typo3/sysext/core/Tests/Functional/Database/QueryGeneratorTest.php: the FQCN of QueryGenerator has changed here too like in typo3/sysext/core/Tests/Unit/Database/QueryGeneratorTest.php -
Christian Kuhn uploaded patch set 6 07/22/21, 09:37
-
Christian Kuhn commented on patch set 6 07/22/21, 09:39
Reply
1. this has been done already. 2. well, ok ... ;) -
core-ci voted on patch set 6 V -1 07/22/21, 09:40 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13650
-
Christian Kuhn uploaded patch set 7 07/22/21, 09:46
-
core-ci voted on patch set 7 V -1 07/22/21, 10:02 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13654
-
Christian Kuhn uploaded patch set 8 07/22/21, 10:32
-
Christian Kuhn updated the commit message in patch set 9 07/22/21, 10:33
-
core-ci voted on patch set 8 V -1 07/22/21, 10:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13661
-
core-ci voted on patch set 9 V -1 07/22/21, 10:51 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13662
-
Christian Kuhn uploaded patch set 10 07/22/21, 11:15
-
core-ci voted on patch set 10 V +1 07/22/21, 11:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13663
-
Benni Mack voted on patch set 10 V +1 CR +1 07/22/21, 13:20
-
Jochen Roth voted on patch set 10 V +1 CR +1 07/22/21, 14:48
-
Christian Kuhn voted on patch set 10 V +2 CR +2 07/22/21, 14:50
-
Christian Kuhn merged patch set 11 07/22/21, 14:51
QueryView.php:41