Review main Merged

69965[FEATURE] Allow icon identifiers in the report module registration

Nikita Hovratov CR +2 V +2 Normal +70 −100 updated 07/27/21, 11:59

Commit message

To further streamline the usage of the IconRegistry, the reports
registration array now allows to define an icon identifier. Absolute
paths and paths with "EXT:" prefix are still possible.

Further improvements:
The IconViewHelper of the reports extension has been dropped. It had
the same functionality as a normal ImageViewHelper with the addition of
a fallback icon. This logic has been moved to the controller action.

Some minor code refactoring and template cleanup while at it.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 912

  1. Nikita Hovratov uploaded patch set 1 07/19/21, 18:18

  2. core-ci voted on patch set 1 V -1 07/19/21, 18:31 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13519

  3. Nikita Hovratov uploaded patch set 2 07/19/21, 18:38

  4. core-ci voted on patch set 2 V +1 07/19/21, 18:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13522

  5. Christian Kuhn commented on patch set 2 07/19/21, 18:50

    ext_localconf.php:14

    Not fully in my head: Are you sure about this? The if() above is done in case some extension registers a status before the reports extension is loaded (load-order-thing). Are you 100% sure ext:reports is always loaded before, when assuming that a consuming extension has a require or suggest relationship to ext:reports? If in doubt, we may simply leave the if() and array_merge() construct for now.
  6. Nikita Hovratov uploaded patch set 3 07/20/21, 07:23

  7. Nikita Hovratov commented on patch set 3 07/20/21, 07:24

    ext_localconf.php:14 Reply

    You are absolutely right. Didn't know about these Status Provider thingies up until now.
  8. core-ci voted on patch set 3 V +1 07/20/21, 07:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13538

  9. Nikita Hovratov commented on patch set 3 07/22/21, 13:01

    ext_localconf.php:14 Reply

    Done
  10. Christian Kuhn voted on patch set 3 V +1 CR +1 07/22/21, 15:23

  11. Benni Mack voted on patch set 3 V +2 CR +2 07/27/21, 11:59

  12. Benni Mack merged patch set 4 07/27/21, 11:59