69965[FEATURE] Allow icon identifiers in the report module registration
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Feature-94590-AllowIconIdentifiersInReportModuleRegistration.rstnew+33 −0
- typo3/sysext/reports/Classes/Controller/ReportController.php+20 −2
- typo3/sysext/reports/Classes/ViewHelpers/IconViewHelper.phpdeleted+0 −86
- typo3/sysext/reports/Resources/Private/Templates/Report/Index.html+15 −11
- typo3/sysext/reports/ext_localconf.php3+2 −1
Review log 912
-
Nikita Hovratov uploaded patch set 1 07/19/21, 18:18
-
core-ci voted on patch set 1 V -1 07/19/21, 18:31 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13519
-
Nikita Hovratov uploaded patch set 2 07/19/21, 18:38
-
core-ci voted on patch set 2 V +1 07/19/21, 18:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13522
-
Christian Kuhn commented on patch set 2 07/19/21, 18:50
-
Nikita Hovratov uploaded patch set 3 07/20/21, 07:23
-
Nikita Hovratov commented on patch set 3 07/20/21, 07:24
ext_localconf.php:14ReplyYou are absolutely right. Didn't know about these Status Provider thingies up until now. -
core-ci voted on patch set 3 V +1 07/20/21, 07:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13538
-
Nikita Hovratov commented on patch set 3 07/22/21, 13:01
ext_localconf.php:14ReplyDone -
Christian Kuhn voted on patch set 3 V +1 CR +1 07/22/21, 15:23
-
Benni Mack voted on patch set 3 V +2 CR +2 07/27/21, 11:59
-
Benni Mack merged patch set 4 07/27/21, 11:59
ext_localconf.php:14