Review 9.5 Merged

69971[TASK] Mitigate downstream CSV code injection

Oliver Hader CR +2 V +2 Hard +292 −6 updated 07/20/21, 08:40

Commit message

* uses stream filter to enclose multi-line content
* adds three choosable strategies dealing with control literals
  + TYPE_REMOVE_CONTROLS - removes control literals (default)
  + TYPE_PREFIX_CONTROLS - prefixes control literal sequence with `'`
  + TYPE_PASSTHROUGH - nothing, passthrough data

The default strategy is `TYPE_REMOVE_CONTROLS` when
invoking `\TYPO3\CMS\Core\Utility\CsvUtility::csvValues`.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 3

Review log 34

  1. Oliver Hader uploaded patch set 1 07/20/21, 08:27

  2. Oliver Hader commented on patch set 1 V +2 CR +2 07/20/21, 08:27

    Auto-approved
  3. Oliver Hader merged patch set 2 07/20/21, 08:27

  4. core-ci voted on patch set 1 V +1 07/20/21, 08:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13544