Review main Merged

69978[BUGFIX] Correctly resolve arrays in log messages

Oli Bartsch CR +2 V +2 Easy +3 −3 updated 07/22/21, 15:24

Commit message

When using an array as data for a log entry placeholder,
it must be imploded as otherwise the placeholder would
not be resolved by AbstractWriter->interpolate().

Additionally, the exception is now correctly added to the
log message string in PhpErrorLogWriter again.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 45

  1. Oli Bartsch uploaded patch set 1 07/20/21, 09:01

  2. core-ci voted on patch set 1 V +1 07/20/21, 09:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13561

  3. Benni Mack voted on patch set 1 V +1 CR +1 07/20/21, 14:36

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 07/22/21, 15:24

  5. Christian Kuhn merged patch set 2 07/22/21, 15:24