Review 10.4 Merged

69986[SECURITY] Do not log sensitive data in authentication process

Oliver Hader CR +2 V +2 Easy +39 −11 updated 07/20/21, 09:38

Commit message

When having the debug logging activated for the
authentication process, sensitive data is not being
logged anymore.

This change
* removes password from being logged
* hashes the cookie value processed for logging

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 1

Review log 34

  1. Oliver Hader uploaded patch set 1 07/20/21, 09:16

  2. Oliver Hader commented on patch set 1 V +2 CR +2 07/20/21, 09:17

    Auto-approved
  3. Oliver Hader merged patch set 2 07/20/21, 09:17

  4. core-ci voted on patch set 1 V +1 07/20/21, 09:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13570