Review 11.3 Merged

69987[SECURITY] Mitigate XSS in viewpage

Oliver Hader CR +2 V +2 Easy +3 −2 updated 07/20/21, 09:40

Commit message

The `viewpage` module contains a preset selection, where
users can select different browser viewports. Since the
corresponding preset labels, configurable via TSconfig,
had not been encoded properly, is was vulnerable to XSS.

The issue is addressed by properly encoding the labels.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 07/20/21, 09:17

  2. Oliver Hader commented on patch set 1 V +2 CR +2 07/20/21, 09:17

    Auto-approved
  3. Oliver Hader merged patch set 2 07/20/21, 09:17

  4. core-ci voted on patch set 1 V +1 07/20/21, 09:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13571