Review main Merged

70012[BUGFIX] Undefined array key with PHP8 in old services API

Devid Messner CR +2 V +2 Easy +4 −1 updated 07/22/21, 09:38

Commit message

Fix a PHP Warning on custom auth services that have
no service subtype "processLoginDataBE".

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Devid Messner uploaded patch set 1 07/20/21, 15:08

  2. core-ci voted on patch set 1 V +1 07/20/21, 15:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13606

  3. Christian Kuhn uploaded patch set 2 07/21/21, 16:17

  4. Christian Kuhn updated the commit message in patch set 3 07/21/21, 16:27

  5. core-ci voted on patch set 2 V +1 07/21/21, 16:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13635

  6. core-ci voted on patch set 3 V +1 07/21/21, 16:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13636

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 07/21/21, 17:06

  8. Georg Ringer voted on patch set 3 V +2 CR +2 07/22/21, 09:38

  9. Georg Ringer merged patch set 4 07/22/21, 09:38