70013[BUGFIX] Fix page layout grid columns
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 8
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumn.php+8 −3
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+2 −1
- typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php+3 −0
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −1
- typo3/sysext/backend/Resources/Private/Language/locallang_layout.xlf+9 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/Column.html+30 −20
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/ColumnHeader.html+4 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record.html+1 −1
Review log 912
-
Oli Bartsch uploaded patch set 1 07/20/21, 16:55
-
core-ci voted on patch set 1 V -1 07/20/21, 17:09 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13609
-
Oli Bartsch uploaded patch set 2 07/20/21, 21:32
-
core-ci voted on patch set 2 V +1 07/20/21, 21:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13611
-
Benni Mack commented on patch set 2 07/22/21, 15:43
I'd say we only fix this in v11 -
Oli Bartsch updated the commit message in patch set 3 07/22/21, 21:38
-
Oli Bartsch commented on patch set 3 07/22/21, 21:39
Reply
Sure, especially because v10 still features PageLayoutView. Changed it accordingly. -
core-ci voted on patch set 3 V +1 07/22/21, 21:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13681
-
Benni Mack voted on patch set 3 V +1 CR +1 07/23/21, 08:58
-
Jochen Roth voted on patch set 3 V +1 CR +1 07/26/21, 10:06
-
Oli Bartsch voted on patch set 3 V +2 CR +2 07/26/21, 10:13
-
Oli Bartsch merged patch set 4 07/26/21, 10:13