Review main Merged

70013[BUGFIX] Fix page layout grid columns

Oli Bartsch CR +2 V +2 Normal +58 −27 updated 07/26/21, 10:13

Commit message

This fixes inconsistency in the display of the grid columns
between the fluid based page module and PageLayoutView.

* Proper distinction between unassigned and unused columns
* State describing classes, such as "restricted" and "hidden"
  are now added correctly
* Access restricted columns do not longer display elements
  previously added to this column
* Column titles are now correct
* TSconfig option "hideRestrictedCols" is respected
* TSconfig option "colPosList" does now work correctly
* All used labels are now translatable
* No more cross dependencies for labels

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 8

Review log 912

  1. Oli Bartsch uploaded patch set 1 07/20/21, 16:55

  2. core-ci voted on patch set 1 V -1 07/20/21, 17:09 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13609

  3. Oli Bartsch uploaded patch set 2 07/20/21, 21:32

  4. core-ci voted on patch set 2 V +1 07/20/21, 21:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13611

  5. Benni Mack commented on patch set 2 07/22/21, 15:43

    I'd say we only fix this in v11
  6. Oli Bartsch updated the commit message in patch set 3 07/22/21, 21:38

  7. Oli Bartsch commented on patch set 3 07/22/21, 21:39

    Reply

    Sure, especially because v10 still features PageLayoutView. Changed it accordingly.
  8. core-ci voted on patch set 3 V +1 07/22/21, 21:47 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13681

  9. Benni Mack voted on patch set 3 V +1 CR +1 07/23/21, 08:58

  10. Jochen Roth voted on patch set 3 V +1 CR +1 07/26/21, 10:06

  11. Oli Bartsch voted on patch set 3 V +2 CR +2 07/26/21, 10:13

  12. Oli Bartsch merged patch set 4 07/26/21, 10:13