Review main Merged

70016[TASK] Migrate Doctrine DBAL fetchAll() to fetchAllAssociative()

Benni Mack CR +2 V +2 Normal +113 −114 updated 07/28/21, 07:41

Commit message

Since TYPO3 uses the \PDO::FETCH_ASSOC fetch mode
by default, fetchAll() is the equivalent for fetchAllAssociative()
which is the new API for Doctrine 3. In order to
move towards the new Doctrine DBAL 3.x API,
this change migrates all fetchAll() calls
to fetchAllAssociative() or fetchFirstColumn().

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 61

Show 41 more files

Review log 711

  1. Benni Mack uploaded patch set 1 07/21/21, 11:41

  2. core-ci voted on patch set 1 V +1 07/21/21, 12:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13622

  3. core-ci commented on patch set 1 07/22/21, 14:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13666

  4. Benni Mack updated the commit message in patch set 2 07/22/21, 15:42

  5. core-ci voted on patch set 2 V +1 07/22/21, 15:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13674

  6. Benni Mack rebased onto patch set 3 07/23/21, 09:03

  7. Benni Mack rebased onto patch set 4 07/26/21, 16:46

  8. core-ci voted on patch set 4 V +1 07/26/21, 17:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13781

  9. Oli Bartsch voted on patch set 4 V +1 CR +1 07/27/21, 12:47

  10. Georg Ringer voted on patch set 4 V +2 CR +2 07/28/21, 07:41

  11. Georg Ringer merged patch set 5 07/28/21, 07:41