Review main Merged

70017[BUGFIX] Extbase ObjectManager can inject PSR ContainerInterface

Christian Kuhn CR +2 V +2 Normal +66 −0 updated 07/21/21, 14:39

Commit message

Legacy Extbase ObjectManager has a symfony DI compiler pass
that registers all DI registered "Foo"Interface aliases
via registerImplementation in Extbase container, too.

This however only works if the target is a class.
The Psr/Container/ContainerInterface is a magic
'service_container' alias, though. In turn, ObjectManager
fails to inject Psr/Container/ContainerInterface.

The patch adds this interface explicitly and adds a
functional test to make sure it works.

We target that patch to both v11 and v10 to simplify
the transition from ObjectManager to symfony based DI.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 710

  1. Christian Kuhn uploaded patch set 1 07/21/21, 12:11

  2. Christian Kuhn updated the commit message in patch set 2 07/21/21, 12:13

  3. core-ci voted on patch set 1 V +1 07/21/21, 12:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13624

  4. core-ci voted on patch set 2 V +1 07/21/21, 12:32 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13626

  5. Benni Mack updated the commit message in patch set 3 07/21/21, 13:16

  6. Benni Mack voted on patch set 3 V +1 CR +1 07/21/21, 13:17

  7. core-ci voted on patch set 3 V +1 07/21/21, 13:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13631

  8. Jochen Roth voted on patch set 3 V +1 CR +1 07/21/21, 14:38

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 07/21/21, 14:39

  10. Christian Kuhn merged patch set 4 07/21/21, 14:39