70019[BUGFIX] Show correct path to typo3 binary in scheduler
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 3550
Show 1725 earlier messages
-
Helmut Hummel uploaded patch set 1 07/21/21, 12:23
-
core-ci voted on patch set 1 V -1 07/21/21, 12:39 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13628
-
Helmut Hummel uploaded patch set 2 07/21/21, 14:16
-
core-ci voted on patch set 2 V +1 07/21/21, 14:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13633
-
Helmut Hummel rebased onto patch set 3 07/26/21, 14:51
-
core-ci voted on patch set 3 V +1 07/26/21, 15:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13764
-
Benni Mack commented on patch set 3 07/28/21, 18:53
Can you explain the benefits of this a bit? -
Christian Kuhn commented on patch set 3 07/29/21, 20:29
What's WIP here? This looks like a great change to get rid of a dependency that should be implemented in core directly. -
Helmut Hummel commented on patch set 3 08/02/21, 15:22
Reply
benefit is that changes to the cli binary do not have to be maintained in two separate repos any more. besides I cleaned up and improved the scheduler to be able to show the path to the binaryReply
forge ticket and agreement that this is the way to go and actually beneficial. -
Christian Kuhn uploaded patch set 4 08/08/21, 14:49
-
Christian Kuhn uploaded patch set 5 08/08/21, 14:51
-
Christian Kuhn commented on patch set 5 08/08/21, 14:52
* removed WIP * dropped cms-cli from composer.json and added replaces * forge issue imho good to go Helmut, what do you think? -
core-ci voted on patch set 4 V -1 08/08/21, 14:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14277
-
Christian Kuhn updated the commit message in patch set 6 08/08/21, 14:59
-
Christian Kuhn uploaded patch set 7 08/08/21, 15:00
-
Christian Kuhn uploaded patch set 8 08/08/21, 15:02
-
core-ci voted on patch set 5 V +1 08/08/21, 15:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14278
-
Christian Kuhn commented on patch set 8 08/08/21, 15:05
Ah, with the composer.json changes from set 5, bin/typo3 is no longer created for the monorepo. Reset to Helmuts patch set 3 version for now, just keeping a commit message change between set 8 and set 3. Sorry for the other pushes, was a bit confused. But hey, I created a forge issue ^^ Any idea how to get bin/typo3 created for the monorepo without having cms-cli as dependency? -
core-ci voted on patch set 7 V +1 08/08/21, 15:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14280
-
core-ci voted on patch set 6 V +1 08/08/21, 15:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14279
-
core-ci voted on patch set 8 V +1 08/08/21, 15:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14281
-
Wouter Wolters commented on patch set 8 CR -1 08/08/21, 15:22
Also check Build/Scripts/checkFilePermissions.sh where the now renamed file is used. -
Christian Kuhn commented on patch set 8 08/08/21, 16:37
Reply
good point. -
Helmut Hummel commented on patch set 8 08/08/21, 16:51
Reply
The script accidentally does exactly the right thing for this change 😊 -
Helmut Hummel uploaded patch set 9 08/08/21, 17:25
-
Helmut Hummel uploaded patch set 10 08/08/21, 17:26
-
core-ci voted on patch set 9 V +1 08/08/21, 17:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14285
-
core-ci voted on patch set 10 V +1 08/08/21, 17:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14286
-
Christian Kuhn voted on patch set 10 V +1 CR +1 08/09/21, 21:44
-
Wouter Wolters voted on patch set 10 CR +1 08/09/21, 21:59
-
Benni Mack wrote 08/13/21, 11:06
Removed reviewer Benni Mack. -
Benni Mack commented on patch set 10 08/13/21, 21:28
Ready to go, but please add an Important.RST so composer owners know about this change. -
Benjamin Franzke commented on patch set 10 V -1 08/28/21, 05:33
composer.json:111Hm… Doesn't work when TYPO3 is installed as path repository (and is thus symlinked). $ vendor/bin/typo3 PHP Warning: require(/home/ben/src/vendor/autoload.php): failed to open stream: No such file or directory in /home/ben/src/TYPO3.CMS/typo3/sysext/core/bin/typo3 on line 21 PHP Fatal error: require(): Failed opening required '/home/ben/src/vendor/autoload.php' (include_path='.:/usr/share/pear:/usr/share/php') in /home/ben/src/TYPO3.CMS/typo3/sysext/core/bin/typo3 on line 21 -
Helmut Hummel commented on patch set 10 10/01/21, 10:50
composer.json:111Reply> Hm… Doesn't work when TYPO3 is installed as path repository (and is thus symlinked). Not a single Composer package that ships a binary works in such case: https://github.com/composer/composer/issues/10119 This means if typo3/cms-cli is linked from a path repository, it currently does not work either. Also the generation of typo3/sysext/core/bin/typo3 binary, changes the SOURCE package in case core is symlinked from a path repository. This means if different instances use the same source, then the last usage will work/win, but other instances will break. All that can't be solved on our end, but must be solved on Composer's end. What we should do though is make sure we use and communicate Composer API instead of implementing our own solutions (with generating a binary file on composer install, which is located in a different folder than any other Composer binaries). And this is what this change aims for. -
Helmut Hummel uploaded patch set 11 10/01/21, 11:04
-
Helmut Hummel uploaded patch set 12 10/01/21, 11:06
-
Helmut Hummel uploaded patch set 13 10/01/21, 11:08
-
core-ci voted on patch set 11 V -1 10/01/21, 11:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17407
-
Helmut Hummel uploaded patch set 14 10/01/21, 11:15
-
core-ci voted on patch set 12 V +1 10/01/21, 11:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17408
-
Helmut Hummel commented on patch set 14 10/01/21, 11:28
composer.json:111ReplyOh, and btw. the generated binary also does not work when typo3/cms-core is symlinked from a path repository... -
core-ci voted on patch set 13 V +1 10/01/21, 11:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17410
-
core-ci voted on patch set 14 V +1 10/01/21, 11:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17411
-
Helmut Hummel uploaded patch set 15 10/01/21, 12:30
-
core-ci voted on patch set 15 V +1 10/01/21, 12:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17423
-
Benjamin Franzke voted on patch set 15 V +1 CR +1 10/01/21, 13:16
-
Benjamin Franzke commented on patch set 15 10/01/21, 13:16
composer.json:111ReplyPostponed. -
Benni Mack voted on patch set 15 V +1 CR +1 10/01/21, 14:51
-
Andreas Kienast voted on patch set 15 V +2 CR +2 10/01/21, 15:02
-
Andreas Kienast merged patch set 16 10/01/21, 15:03