Review main Merged

70020[BUGFIX] Use ForwardResponse arguments if not null

Alexander Schnitzler CR +2 V +2 Easy +4 −4 updated 07/22/21, 09:47

Commit message

Issue #92815 introduced a regression which triggered an endless
recursion in case of a validation error.

A bit longer explanation:

Given there is an extbase controller action with an argument
whose properties have to validated, extbase maps the incoming
data of the request onto the internally handled arguments
object which then performs the validation on all given arguments.

In case of an error, extbase tries to redirect to the referring
request aka the current request with an updated set of arguments.
The idea is to remove all arguments of the current request to not
trigger the same validation error again on the next try.

There was a condition in the past which eventually led to the
overriding of current arguments which was refactored wrong.

The solution is to make the arguments of the ForwardResponse null
by default and have the same null check like before.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • waldhacker +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • waldhacker +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Alexander Schnitzler uploaded patch set 1 07/21/21, 12:58

  2. Alexander Schnitzler uploaded patch set 2 07/21/21, 13:00

  3. core-ci voted on patch set 1 V -1 07/21/21, 13:00 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13629

  4. Alexander Schnitzler wrote 07/21/21, 13:01

    Topic set to extbase
  5. Alexander Schnitzler wrote 07/21/21, 13:01

    Hashtag added: validation
  6. core-ci voted on patch set 2 V +1 07/21/21, 13:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13630

  7. Alexander Schnitzler commented on patch set 2 07/21/21, 13:25

    This change is ready for review.
  8. Christian Kuhn voted on patch set 2 V +1 CR +1 07/21/21, 16:10

  9. waldhacker voted on patch set 2 V +1 CR +1 07/22/21, 05:58

  10. Oli Bartsch voted on patch set 2 V +1 CR +1 07/22/21, 07:57

  11. Christian Kuhn voted on patch set 2 V +2 CR +2 07/22/21, 09:47

  12. Christian Kuhn merged patch set 3 07/22/21, 09:47