Review main Merged

70022[BUGFIX] Respect TCA type language in getProcessedValue

Oli Bartsch CR +2 V +2 Normal +72 −4 updated 07/22/21, 14:54

Commit message

Since #57082 the language columns, typically
`sys_language_uid`, are defined with the new
TCA type "language" instead of type "select".

Since this was previously not properly handled,
BackendUtility::getProcessedValue() just returned
the records' field value instead of the language title.

This is now fixed by adding an additional "case" for
TCA type "language".

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 913

  1. Oli Bartsch uploaded patch set 1 07/21/21, 16:54

  2. core-ci voted on patch set 1 V -1 07/21/21, 17:06 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13639

  3. Oli Bartsch uploaded patch set 2 07/22/21, 07:49

  4. core-ci voted on patch set 2 V +1 07/22/21, 08:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13646

  5. Oli Bartsch uploaded patch set 3 07/22/21, 08:13

  6. core-ci voted on patch set 3 V +1 07/22/21, 08:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13647

  7. Benni Mack voted on patch set 3 V +1 CR +1 07/22/21, 13:25

  8. Benni Mack updated the commit message in patch set 4 07/22/21, 13:26

  9. Benni Mack voted on patch set 4 V +1 CR +1 07/22/21, 13:26

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 07/22/21, 13:30

  11. core-ci voted on patch set 4 V +1 07/22/21, 13:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13667

  12. Christian Kuhn voted on patch set 4 V +2 CR +2 07/22/21, 14:54

  13. Christian Kuhn merged patch set 5 07/22/21, 14:54