Review main Merged

70023[TASK] Make runTests.sh compatible with docker-compose v2

Jochen Roth CR +2 V +2 Normal +48 −48 updated 07/22/21, 14:55

Commit message

docker-compose.yml is now working with v2.0.0beta.
Restored old behavior to retrieve the actual CORE_ROOT
path using "realpath" which also works on MacOS.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Jochen Roth uploaded patch set 1 07/21/21, 17:47

  2. core-ci voted on patch set 1 V -1 07/21/21, 18:02 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13640

  3. Jochen Roth uploaded patch set 2 07/22/21, 07:34

  4. core-ci voted on patch set 2 V +1 07/22/21, 07:45 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13645

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 07/22/21, 09:05

  6. Christian Kuhn updated the commit message in patch set 3 07/22/21, 09:06

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 07/22/21, 09:07

  8. core-ci voted on patch set 3 V +1 07/22/21, 09:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13648

  9. Benni Mack voted on patch set 3 V +1 CR +1 07/22/21, 13:21

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 07/22/21, 14:55

  11. Christian Kuhn merged patch set 4 07/22/21, 14:55