Review main Merged

70024[BUFIX] Set fallback for undefined array keys in PHP8

Jochen Roth CR +2 V +2 Easy +14 −14 updated 07/23/21, 09:04

Commit message

Fix undefined array keys in form, core and
indexed_search for the frontend and in
extensionmanager.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 710

  1. Jochen Roth uploaded patch set 1 07/22/21, 09:53

  2. core-ci voted on patch set 1 V -1 07/22/21, 10:08 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13656

  3. Jochen Roth uploaded patch set 2 07/22/21, 10:12

  4. core-ci voted on patch set 2 V -1 07/22/21, 10:27 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13660

  5. Oli Bartsch commented on patch set 2 07/22/21, 10:28

    PageRepository.php:1123 Unresolved

    This has to be ($pageRec['l10n_parent'] ?? false) ?: $pageRec['uid'] ?? 0

    FormFrontendController.php:120 Unresolved

    Let's make this `?? false`
  6. Jochen Roth uploaded patch set 3 07/23/21, 07:53

  7. core-ci voted on patch set 3 V +1 07/23/21, 08:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13685

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 07/23/21, 08:42

  9. Benni Mack voted on patch set 3 V +2 CR +2 07/23/21, 09:04

  10. Benni Mack merged patch set 4 07/23/21, 09:04