Review main Merged

70054[TASK] Deprecate extbase ObjectManager

Christian Kuhn CR +2 V +2 Normal +179 −33 updated 07/23/21, 13:35

Commit message

With all non-legacy usages of ObjectManager being gone,
this final patch adds a series of @deprecation annotations
throughout the core, adapts some comments, and finally
adds a trigger_error() to ObjectManager->get().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 32

Show 12 more files

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/22/21, 17:00

  2. core-ci voted on patch set 1 V +1 07/22/21, 17:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13677

  3. Christian Kuhn uploaded patch set 2 07/22/21, 18:05

  4. core-ci voted on patch set 2 V +1 07/22/21, 18:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13679

  5. Benni Mack voted on patch set 2 V +1 CR +1 07/23/21, 08:01

  6. Jochen Roth voted on patch set 2 V +1 CR +1 07/23/21, 12:28

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 07/23/21, 13:34

  8. Christian Kuhn merged patch set 3 07/23/21, 13:35