Review main Merged

70057[BUGFIX] Make QueryGenerator handle multiple label_alt columns

Krzysztof Gutkowski CR +2 V +2 Easy +3 −3 updated 08/16/21, 07:10

Commit message

The label_alt field in TCA is a comma separated list of database
columns, so it needs to be exploded before being passed into a
database query.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Guido Schmechel +1
    • Marcin Sągol +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 3038

Show 1013 earlier messages
  1. Krzysztof Gutkowski uploaded patch set 1 07/23/21, 09:43

  2. core-ci voted on patch set 1 V +1 07/23/21, 09:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13686

  3. Guido Schmechel commented on patch set 1 07/30/21, 23:26

    QueryGenerator.php:918

    Should we use Generalutility::trimExplode instead? I think about my old extensions which has often altLabel with "field1, field2". This could then end in an SQL error?
  4. Krzysztof Gutkowski uploaded patch set 2 08/02/21, 11:32

  5. Krzysztof Gutkowski commented on patch set 2 08/02/21, 11:35

    QueryGenerator.php:918 Reply

    Done
  6. core-ci voted on patch set 2 V +1 08/02/21, 12:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13989

  7. Wouter Wolters voted on patch set 2 CR +1 08/12/21, 19:01

  8. Rudy Gnodde voted on patch set 2 CR +1 08/13/21, 09:43

  9. Andreas Kienast voted on patch set 2 CR +1 08/13/21, 09:49

  10. Krzysztof Gutkowski uploaded patch set 3 08/13/21, 10:08

  11. Andreas Kienast voted on patch set 3 CR +1 08/13/21, 10:11

  12. Wouter Wolters voted on patch set 3 CR +1 08/13/21, 10:12

  13. core-ci voted on patch set 3 V -1 08/13/21, 10:25 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14921

  1. core-ci voted on patch set 3 V +1 08/13/21, 10:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14921

  2. Guido Schmechel voted on patch set 3 CR +1 08/13/21, 10:40

  3. Marcin Sągol commented on patch set 3 08/13/21, 11:15

    QueryGenerator.php:919

    Maybe add third parameter set to `true` for GeneralUtility::trimExplode() to skip empty values?

    QueryGenerator.php:2051

    Maybe add third parameter set to `true` for GeneralUtility::trimExplode() to skip empty values?
  4. Krzysztof Gutkowski uploaded patch set 4 08/13/21, 11:40

  5. Krzysztof Gutkowski commented on patch set 4 08/13/21, 11:41

    QueryGenerator.php:919 Reply

    Done

    QueryGenerator.php:2051 Reply

    Done
  6. core-ci voted on patch set 4 V +1 08/13/21, 12:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14949

  7. Guido Schmechel voted on patch set 4 CR +1 08/13/21, 12:12

  8. Marcin Sągol commented on patch set 4 V +1 CR +1 08/13/21, 12:35

    Tested locally - works fine.
  9. Krzysztof Gutkowski uploaded patch set 5 08/14/21, 12:13

  10. core-ci voted on patch set 5 V +1 08/14/21, 12:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15066

  11. Krzysztof Gutkowski updated the commit message in patch set 6 08/14/21, 12:37

  12. Stefan Bürk commented on patch set 5 CR -1 08/14/21, 12:39

    Would like to see some tests for it. So adding testcases would be nice, for lowwele there are unit/functional tests already there and should at least add some tests for it. Not found on quickserch tests for the core QueryGenerator, at lease some functional tests there would be nice too.
  13. Krzysztof Gutkowski updated the commit message in patch set 7 08/14/21, 12:43

  14. Tymoteusz Motylewski voted on patch set 7 V +1 CR +1 08/14/21, 12:45

  15. core-ci voted on patch set 6 V +1 08/14/21, 12:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15069

  16. Tymoteusz Motylewski commented on patch set 7 08/14/21, 12:59

    Reply

    Writing tests to this patch requires creation of new fixtures - you need to create a relation to a table which does use label_alt. And then you can write functional/acceptance tests for it. I think this can be done in a separate issue not to block this fix.
  17. Stefan Bürk commented on patch set 7 08/14/21, 12:59

    Not sure - but still, would prefere to have some tests (unit/functional) for it ...
  18. Stefan Bürk commented on patch set 7 CR +1 08/14/21, 13:02

    Reply

    Maybe you are right, you are more experiend with core workflow. But if you prefere to do it that way, i would not block it. (just wanted to get another opionion about it)

    Reply

    Forget it ;)
  19. core-ci voted on patch set 7 V +1 08/14/21, 13:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15071

  20. Tymoteusz Motylewski commented on patch set 7 08/14/21, 13:07

    Reply

    Sure, we definitely needs test in this area. If you want, you can start with extending the acceptance tests sysext/core/Tests/Acceptance/Backend/DbCheck/DbCheckModuleCest.php which could be extended to test recent fixes like https://review.typo3.org/c/Packages/TYPO3.CMS/+/70539 and this one.
  21. Stefan Bürk voted on patch set 7 V +1 08/14/21, 18:30

  22. Guido Schmechel voted on patch set 7 CR +1 08/15/21, 10:27

  23. Tymoteusz Motylewski voted on patch set 7 V +2 CR +2 08/16/21, 06:02

  24. Tymoteusz Motylewski merged patch set 8 08/16/21, 06:02

  25. Marcin Sągol voted on patch set 8 CR +1 08/16/21, 07:10