Review main Merged

70059[BUGFIX] Cast $siteUrl to string

Jochen Roth CR +2 V +2 Easy +14 −1 updated 07/26/21, 16:58

Commit message

In case substr returns false $siteUrl
is now casted to string and covered
by an additional unit test.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Jochen Roth uploaded patch set 1 07/23/21, 12:07

  2. Christian Kuhn commented on patch set 1 07/23/21, 12:23

    NormalizedParams.php:829 Unresolved

    not entirely sure, but a unit test for this case you're fixing here could / should be possible?
  3. core-ci voted on patch set 1 V +1 07/23/21, 12:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13692

  4. Jochen Roth uploaded patch set 2 07/26/21, 10:21

  5. core-ci voted on patch set 2 V +1 07/26/21, 10:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13746

  6. Jochen Roth uploaded patch set 3 07/26/21, 10:35

  7. Jochen Roth uploaded patch set 4 07/26/21, 10:36

  8. Oli Bartsch voted on patch set 4 V +1 CR +1 07/26/21, 10:37

  9. core-ci voted on patch set 3 V +1 07/26/21, 10:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13747

  10. core-ci voted on patch set 4 V +1 07/26/21, 10:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13748

  11. Oliver Klee voted on patch set 4 CR +1 07/26/21, 11:19

  12. Oliver Klee commented on patch set 4 07/26/21, 11:19

    Should we also have this in 10.4?
  13. Jochen Roth commented on patch set 4 07/26/21, 12:58

    Reply

    Hmmm ... well, that should do no harm in 10.4 Just notices it while working on Command Testing for Styleguide Generators: https://github.com/TYPO3/styleguide/pull/229
  14. Benni Mack voted on patch set 4 V +2 CR +2 07/26/21, 16:58

  15. Benni Mack merged patch set 5 07/26/21, 16:58