70059[BUGFIX] Cast $siteUrl to string
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1115
-
Jochen Roth uploaded patch set 1 07/23/21, 12:07
-
Christian Kuhn commented on patch set 1 07/23/21, 12:23
-
core-ci voted on patch set 1 V +1 07/23/21, 12:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13692
-
Jochen Roth uploaded patch set 2 07/26/21, 10:21
-
core-ci voted on patch set 2 V +1 07/26/21, 10:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13746
-
Jochen Roth uploaded patch set 3 07/26/21, 10:35
-
Jochen Roth uploaded patch set 4 07/26/21, 10:36
-
Oli Bartsch voted on patch set 4 V +1 CR +1 07/26/21, 10:37
-
core-ci voted on patch set 3 V +1 07/26/21, 10:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13747
-
core-ci voted on patch set 4 V +1 07/26/21, 10:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13748
-
Oliver Klee voted on patch set 4 CR +1 07/26/21, 11:19
-
Oliver Klee commented on patch set 4 07/26/21, 11:19
Should we also have this in 10.4? -
Jochen Roth commented on patch set 4 07/26/21, 12:58
Reply
Hmmm ... well, that should do no harm in 10.4 Just notices it while working on Command Testing for Styleguide Generators: https://github.com/TYPO3/styleguide/pull/229 -
Benni Mack voted on patch set 4 V +2 CR +2 07/26/21, 16:58
-
Benni Mack merged patch set 5 07/26/21, 16:58
NormalizedParams.php:829Unresolved